diff mbox series

net/octeontx_ep: do not use a NULL Pointer

Message ID 20210524085935.16403-1-thierry.herbelot@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series net/octeontx_ep: do not use a NULL Pointer |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/iol-abi-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-testing fail Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-mellanox-Functional fail Functional Testing issues
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Thierry Herbelot May 24, 2021, 8:59 a.m. UTC 
  mz is known to be NULL: do not use it to print a memzone name.

Fixes: 242e18c056890 ("net/octeontx_ep: add Rx queue setup and release")
Cc: stable@dpdk.org
Cc: Nalla Pradeep <pnalla@marvell.com>
Cc: Radha Mohan Chintakuntla <radhac@marvell.com>
Cc: Veerasenareddy Burru <vburru@marvell.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 drivers/net/octeontx_ep/otx_ep_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jerin Jacob June 29, 2021, 6:09 p.m. UTC | #1 
On Mon, May 24, 2021 at 2:30 PM Thierry Herbelot
<thierry.herbelot@6wind.com> wrote:
>
> mz is known to be NULL: do not use it to print a memzone name.
>
> Fixes: 242e18c056890 ("net/octeontx_ep: add Rx queue setup and release")
> Cc: stable@dpdk.org
> Cc: Nalla Pradeep <pnalla@marvell.com>
> Cc: Radha Mohan Chintakuntla <radhac@marvell.com>
> Cc: Veerasenareddy Burru <vburru@marvell.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>

Changed the git log to following and Applied to
dpdk-next-net-mrvl/for-next-net. Thanks

Author: Thierry Herbelot <thierry.herbelot@6wind.com>
Date:   Mon May 24 10:59:35 2021 +0200

    net/octeontx_ep: fix null pointer access

    mz is known to be NULL. Do not use it to print a memzone name.

    Fixes: 242e18c056890 ("net/octeontx_ep: add Rx queue setup and release")
    Cc: stable@dpdk.org

    Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>

> ---
>  drivers/net/octeontx_ep/otx_ep_rxtx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/octeontx_ep/otx_ep_rxtx.c b/drivers/net/octeontx_ep/otx_ep_rxtx.c
> index 28ff74d2d5b0..a7d433547e36 100644
> --- a/drivers/net/octeontx_ep/otx_ep_rxtx.c
> +++ b/drivers/net/octeontx_ep/otx_ep_rxtx.c
> @@ -27,7 +27,7 @@ otx_ep_dmazone_free(const struct rte_memzone *mz)
>         int ret = 0;
>
>         if (mz == NULL) {
> -               otx_ep_err("Memzone %s : NULL\n", mz->name);
> +               otx_ep_err("Memzone: NULL\n");
>                 return;
>         }
>
> --
> 2.29.2
>
diff mbox series

Patch

diff --git a/drivers/net/octeontx_ep/otx_ep_rxtx.c b/drivers/net/octeontx_ep/otx_ep_rxtx.c
index 28ff74d2d5b0..a7d433547e36 100644
--- a/drivers/net/octeontx_ep/otx_ep_rxtx.c
+++ b/drivers/net/octeontx_ep/otx_ep_rxtx.c
@@ -27,7 +27,7 @@  otx_ep_dmazone_free(const struct rte_memzone *mz)
 	int ret = 0;
 
 	if (mz == NULL) {
-		otx_ep_err("Memzone %s : NULL\n", mz->name);
+		otx_ep_err("Memzone: NULL\n");
 		return;
 	}