From patchwork Tue May 18 07:07:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 93294 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CEF7A0548; Tue, 18 May 2021 09:07:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E62784068E; Tue, 18 May 2021 09:07:49 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id C50A240041 for ; Tue, 18 May 2021 09:07:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621321666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o7RlQPGe9+7WMvlnzcCyUOMPPPC5RQ/fEK1VKfdtPyE=; b=XqGxB3jLavy+7sL3Bhhk7DS/V//p99x3fzU3dFtlXkznORafg8PiBSSRbhVfBgAfZMzdem yMfMRk5SjEpSQDRJuYe7dPbCOwFA22uwChfUHQG4ivxk+9bC1gEbn2xYoILJaSbkrwcv+W 4/4Z69IZOzweByuQ49+XLwZHFygMfJc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-7ksjUjihOdGG9MqetqT6NA-1; Tue, 18 May 2021 03:07:45 -0400 X-MC-Unique: 7ksjUjihOdGG9MqetqT6NA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 084AD107ACE4; Tue, 18 May 2021 07:07:44 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B61A614ED; Tue, 18 May 2021 07:07:38 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@intel.com, Maxime Coquelin , Chenbo Xia Date: Tue, 18 May 2021 09:07:27 +0200 Message-Id: <20210518070728.15341-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] net/vhost: restore pseudo TSO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The net/vhost pmd does not comply with the ethdev offload API as it does not report rx/tx offload capabilities wrt TSO and checksum offloading. On the other hand, the net/vhost pmd lets guest negotiates TSO and checksum offloading. Changing the behavior for rx/tx offload flags handling won't improve/fix this situation and will break applications that might have been relying on implicit support of TSO in this driver. Revert this behavior change until we have a complete fix. Fixes: ca7036b4af3a ("vhost: fix offload flags in Rx path") Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin --- The full fix requires: - reporting rx/tx_offload_capa, - supporting sw TSO and checksums for the case when a virtual machine negotiates this feature, but the application does not configure DEV_[RT]X_OFFLOAD_* appropriate flags, --- drivers/net/vhost/rte_eth_vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 8524898661..a202931e9a 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -1505,7 +1505,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) int ret = 0; char *iface_name; uint16_t queues; - uint64_t flags = RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS; + uint64_t flags = 0; uint64_t disable_flags = 0; int client_mode = 0; int iommu_support = 0;