| Message ID | 20210511021116.30844-1-alvinx.zhang@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Qi Zhang |
| Headers | show |
| Series | [v2] net/iavf: fix error logs | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-abi-testing | success | Testing PASS |
| ci/iol-testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/github-robot | success | github build: passed |
| ci/intel-Testing | success | Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index ca5c56e..dfa7ce3 100644 --- a/drivers/net/iavf/iavf_vchnl.c +++ b/drivers/net/iavf/iavf_vchnl.c @@ -1519,11 +1519,8 @@ args.out_size = IAVF_AQ_BUF_SZ; err = iavf_execute_vf_cmd(adapter, &args); - if (err) { - PMD_DRV_LOG(ERR, - "Failed to execute command of OP_GET_RSS_HENA_CAPS"); + if (err) return err; - } *caps = ((struct virtchnl_rss_hena *)args.out_buffer)->hena; return 0; @@ -1535,7 +1532,6 @@ struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter); struct virtchnl_rss_hena vrh; struct iavf_cmd_info args; - int err; vrh.hena = hena; args.ops = VIRTCHNL_OP_SET_RSS_HENA; @@ -1544,12 +1540,7 @@ args.out_buffer = vf->aq_resp; args.out_size = IAVF_AQ_BUF_SZ; - err = iavf_execute_vf_cmd(adapter, &args); - if (err) - PMD_DRV_LOG(ERR, - "Failed to execute command of OP_SET_RSS_HENA"); - - return err; + return iavf_execute_vf_cmd(adapter, &args); } int
Remove some useless logs which are duplicated of the lower-level function logs and may confuse users when running VF without some features that not supported by PF. Fixes: 5a038d19962d ("net/iavf: fix RSS configuration on i40e VF") Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS") Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com> --- drivers/net/iavf/iavf_vchnl.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)