[v2] log: register with standardized names

  Let's try to enforce the convention where drivers use a pmd. logtype
with their class reflected in it and libraries use a lib. logtype.

Introduce two new macros:
- RTE_LOG_REGISTER_DEFAULT can be used when a single logtype is
  used in a component. It is associated to the default name provided
  by the build system,
- RTE_LOG_REGISTER_SUFFIX can be used when multiple logtypes are used,
  and then the passed name is appended to the default name,

RTE_LOG_REGISTER is left untouched for existing external users and for
components that do not comply with the convention.

Note: achieved with below commands + reverted change on net/bonding +
edits on crypto/virtio, compress/mlx5 and regex/mlx5

$ git grep -l RTE_LOG_REGISTER drivers/ |
  while read file; do
    pattern=${file##drivers/};
    class=${pattern%%/*};
    pattern=${pattern#$class/};
    pattern=pmd.$class.${pattern%%/*};
    sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern',/RTE_LOG_REGISTER_DEFAULT(\1,/' $file;
    sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern'\.\(.*\),/RTE_LOG_REGISTER_SUFFIX(\1, \2,/' $file;
  done

$ git grep -l RTE_LOG_REGISTER lib/ |
  while read file; do
    pattern=${file##lib/};
    pattern=lib.${pattern%%/*};
    sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern',/RTE_LOG_REGISTER_DEFAULT(\1,/' $file;
    sed -i -e 's/RTE_LOG_REGISTER(\(.*\), '$pattern'\.\(.*\),/RTE_LOG_REGISTER_SUFFIX(\1, \2,/' $file;
  done

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changes since v1:
- moved default logtype generation in the build system,
- rebased,
- reverted net/bonding change,

---
 drivers/common/dpaax/dpaax_iova_table.c       |  2 +-
 drivers/common/iavf/iavf_impl.c               |  2 +-
 drivers/common/mlx5/mlx5_common.c             |  2 +-
 drivers/compress/isal/isal_compress_pmd.c     |  2 +-
 drivers/compress/mlx5/mlx5_compress.c         |  3 +-
 drivers/compress/octeontx/otx_zip_pmd.c       |  2 +-
 drivers/compress/zlib/zlib_pmd.c              |  2 +-
 drivers/crypto/aesni_gcm/aesni_gcm_pmd.c      |  2 +-
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c    |  2 +-
 drivers/crypto/armv8/rte_armv8_pmd.c          |  2 +-
 drivers/crypto/bcmfs/bcmfs_logs.c             |  4 +-
 drivers/crypto/kasumi/rte_kasumi_pmd.c        |  2 +-
 drivers/crypto/mvsam/rte_mrvl_pmd.c           |  2 +-
 drivers/crypto/nitrox/nitrox_logs.c           |  2 +-
 drivers/crypto/null/null_crypto_pmd.c         |  2 +-
 drivers/crypto/octeontx/otx_cryptodev.c       |  2 +-
 drivers/crypto/octeontx2/otx2_cryptodev.c     |  2 +-
 drivers/crypto/openssl/rte_openssl_pmd.c      |  2 +-
 .../scheduler/rte_cryptodev_scheduler.c       |  2 +-
 drivers/crypto/snow3g/rte_snow3g_pmd.c        |  2 +-
 drivers/crypto/virtio/virtio_cryptodev.c      | 12 +++---
 drivers/crypto/zuc/rte_zuc_pmd.c              |  2 +-
 drivers/event/dlb2/dlb2.c                     |  2 +-
 drivers/event/dpaa/dpaa_eventdev.c            |  2 +-
 drivers/event/dpaa2/dpaa2_eventdev.c          |  2 +-
 drivers/event/octeontx/ssovf_evdev.c          |  2 +-
 drivers/event/octeontx/timvf_evdev.c          |  2 +-
 drivers/event/opdl/opdl_evdev.c               |  2 +-
 drivers/event/sw/sw_evdev.c                   |  2 +-
 drivers/mempool/octeontx/octeontx_fpavf.c     |  2 +-
 drivers/meson.build                           |  1 +
 drivers/net/af_packet/rte_eth_af_packet.c     |  2 +-
 drivers/net/af_xdp/rte_eth_af_xdp.c           |  2 +-
 drivers/net/ark/ark_ethdev.c                  |  2 +-
 drivers/net/atlantic/atl_ethdev.c             |  4 +-
 drivers/net/avp/avp_ethdev.c                  |  2 +-
 drivers/net/axgbe/axgbe_ethdev.c              |  4 +-
 drivers/net/bnx2x/bnx2x_ethdev.c              |  4 +-
 drivers/net/bnxt/bnxt_ethdev.c                |  2 +-
 drivers/net/bonding/rte_eth_bond_pmd.c        |  3 ++
 drivers/net/cxgbe/cxgbe_ethdev.c              |  4 +-
 drivers/net/dpaa/dpaa_ethdev.c                |  2 +-
 drivers/net/dpaa2/dpaa2_ethdev.c              |  2 +-
 drivers/net/e1000/e1000_logs.c                |  8 ++--
 drivers/net/ena/ena_ethdev.c                  | 12 +++---
 drivers/net/enetc/enetc_ethdev.c              |  2 +-
 drivers/net/enic/enic_ethdev.c                |  2 +-
 drivers/net/failsafe/failsafe.c               |  2 +-
 drivers/net/fm10k/fm10k_ethdev.c              |  8 ++--
 drivers/net/hinic/hinic_pmd_ethdev.c          |  2 +-
 drivers/net/hns3/hns3_ethdev.c                |  4 +-
 drivers/net/i40e/i40e_ethdev.c                |  8 ++--
 drivers/net/iavf/iavf_ethdev.c                |  8 ++--
 drivers/net/ice/ice_ethdev.c                  |  8 ++--
 drivers/net/igc/igc_logs.c                    |  4 +-
 drivers/net/ionic/ionic_ethdev.c              |  2 +-
 drivers/net/ipn3ke/ipn3ke_ethdev.c            |  2 +-
 drivers/net/ixgbe/ixgbe_ethdev.c              |  8 ++--
 drivers/net/kni/rte_eth_kni.c                 |  2 +-
 drivers/net/liquidio/lio_ethdev.c             |  4 +-
 drivers/net/memif/rte_eth_memif.c             |  2 +-
 drivers/net/mlx4/mlx4.c                       |  2 +-
 drivers/net/mlx5/mlx5.c                       |  2 +-
 drivers/net/mvneta/mvneta_ethdev.c            |  2 +-
 drivers/net/mvpp2/mrvl_ethdev.c               |  2 +-
 drivers/net/netvsc/hn_ethdev.c                |  4 +-
 drivers/net/nfp/nfp_net.c                     |  4 +-
 drivers/net/null/rte_eth_null.c               |  2 +-
 drivers/net/octeontx/octeontx_ethdev.c        |  6 +--
 drivers/net/octeontx_ep/otx_ep_ethdev.c       |  2 +-
 drivers/net/pcap/pcap_ethdev.c                |  2 +-
 drivers/net/pfe/pfe_ethdev.c                  |  2 +-
 drivers/net/qede/qede_ethdev.c                |  4 +-
 drivers/net/ring/rte_eth_ring.c               |  2 +-
 drivers/net/softnic/rte_eth_softnic.c         |  2 +-
 drivers/net/szedata2/rte_eth_szedata2.c       |  4 +-
 drivers/net/tap/rte_eth_tap.c                 |  2 +-
 drivers/net/thunderx/nicvf_ethdev.c           |  6 +--
 drivers/net/txgbe/txgbe_ethdev.c              | 12 +++---
 drivers/net/vdev_netvsc/vdev_netvsc.c         |  2 +-
 drivers/net/vhost/rte_eth_vhost.c             |  2 +-
 drivers/net/virtio/virtio_ethdev.c            |  4 +-
 drivers/net/vmxnet3/vmxnet3_ethdev.c          |  4 +-
 drivers/raw/ifpga/ifpga_rawdev.c              |  2 +-
 drivers/raw/ioat/ioat_rawdev.c                |  2 +-
 drivers/raw/ntb/ntb.c                         |  2 +-
 drivers/raw/skeleton/skeleton_rawdev.c        |  2 +-
 drivers/regex/mlx5/mlx5_regex.c               |  3 +-
 drivers/vdpa/mlx5/mlx5_vdpa.c                 |  2 +-
 lib/bbdev/rte_bbdev.c                         |  2 +-
 lib/bpf/bpf.c                                 |  2 +-
 lib/cfgfile/rte_cfgfile.c                     |  2 +-
 lib/compressdev/rte_compressdev.c             |  2 +-
 lib/eal/include/rte_log.h                     | 41 +++++++++++++++----
 lib/ethdev/rte_ethdev.c                       |  2 +-
 lib/eventdev/rte_event_timer_adapter.c        |  6 +--
 lib/flow_classify/rte_flow_classify.c         |  2 +-
 lib/graph/graph.c                             |  2 +-
 lib/member/rte_member.c                       |  2 +-
 lib/meson.build                               |  1 +
 lib/metrics/rte_metrics_telemetry.c           |  2 +-
 lib/net/rte_net_crc.c                         |  2 +-
 lib/node/log.c                                |  2 +-
 lib/pdump/rte_pdump.c                         |  2 +-
 lib/rawdev/rte_rawdev.c                       |  2 +-
 lib/rcu/rte_rcu_qsbr.c                        |  2 +-
 lib/stack/rte_stack.c                         |  2 +-
 lib/vhost/vhost.c                             |  4 +-
 108 files changed, 194 insertions(+), 170 deletions(-)

Message ID	20210426125108.20373-1-david.marchand@redhat.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com Date: Mon, 26 Apr 2021 14:51:08 +0200 Message-Id: <20210426125108.20373-1-david.marchand@redhat.com> In-Reply-To: <20210409124334.24479-1-david.marchand@redhat.com> References: <20210409124334.24479-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v2] log: register with standardized names Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	[v2] log: register with standardized names \| [v2] log: register with standardized names

Context	Check	Description
ci/checkpatch	warning	coding style issues
ci/iol-intel-Functional	success	Functional Testing PASS
ci/iol-intel-Performance	success	Performance Testing PASS
ci/github-robot	success	github build: passed
ci/Intel-compilation	success	Compilation OK
ci/iol-abi-testing	success	Testing PASS
ci/iol-testing	success	Testing PASS
ci/intel-Testing	success	Testing PASS
ci/iol-mellanox-Performance	success	Performance Testing PASS

[v2] log: register with standardized names

Checks

Commit Message

Patch