diff mbox series

net/bnxt: fix FW unregister log

Message ID 20210406060403.29938-1-kalesh-anakkur.purayil@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Ajit Khaparde
Headers
Series net/bnxt: fix FW unregister log |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success travis build: passed
ci/github-robot success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

Kalesh A P April 6, 2021, 6:04 a.m. UTC 
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

The "Unregistered with fw" message was being logged in a wrong function.
Moved it to the right place.

Fixes: a7dda7e0a00b ("net/bnxt: log port id in async events")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Ajit Khaparde April 7, 2021, 3:05 a.m. UTC | #1 
On Mon, Apr 5, 2021 at 10:42 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> The "Unregistered with fw" message was being logged in a wrong function.
> Moved it to the right place.
>
> Fixes: a7dda7e0a00b ("net/bnxt: log port id in async events")
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Patch applied to dpdk-next-net-brcm.

> ---
>  drivers/net/bnxt/bnxt_hwrm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index 6a70b6e..a119fc3 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -1364,6 +1364,9 @@ int bnxt_hwrm_func_driver_unregister(struct bnxt *bp, uint32_t flags)
>         HWRM_CHECK_RESULT();
>         HWRM_UNLOCK();
>
> +       PMD_DRV_LOG(DEBUG, "Port %u: Unregistered with fw\n",
> +                   bp->eth_dev->data->port_id);
> +
>         return rc;
>  }
>
> @@ -1448,8 +1451,6 @@ static int bnxt_hwrm_port_phy_cfg(struct bnxt *bp, struct bnxt_link_info *conf)
>         HWRM_CHECK_RESULT();
>         HWRM_UNLOCK();
>
> -       PMD_DRV_LOG(DEBUG, "Port %u: Unregistered with fw\n",
> -                   bp->eth_dev->data->port_id);
>         return rc;
>  }
>
> --
> 2.10.1
>
diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 6a70b6e..a119fc3 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -1364,6 +1364,9 @@  int bnxt_hwrm_func_driver_unregister(struct bnxt *bp, uint32_t flags)
 	HWRM_CHECK_RESULT();
 	HWRM_UNLOCK();
 
+	PMD_DRV_LOG(DEBUG, "Port %u: Unregistered with fw\n",
+		    bp->eth_dev->data->port_id);
+
 	return rc;
 }
 
@@ -1448,8 +1451,6 @@  static int bnxt_hwrm_port_phy_cfg(struct bnxt *bp, struct bnxt_link_info *conf)
 	HWRM_CHECK_RESULT();
 	HWRM_UNLOCK();
 
-	PMD_DRV_LOG(DEBUG, "Port %u: Unregistered with fw\n",
-		    bp->eth_dev->data->port_id);
 	return rc;
 }