From patchwork Fri Mar 12 05:58:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 88987 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20D73A0547; Fri, 12 Mar 2021 06:59:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BC7A1607BD; Fri, 12 Mar 2021 06:58:38 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id E412D16086E for ; Fri, 12 Mar 2021 06:58:34 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id q12so948285plr.1 for ; Thu, 11 Mar 2021 21:58:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=ttz6kfP/FjYYewJpjDi05zw+iSb1FAE42Xw+XFNmff0=; b=CoAWUbSKwpJ/Kj0a9ALAgNWmmIq5T9/q+R5qdy63wPmcWIF4lkX4xp5iZCXjn7k0s7 DxkhsjS+r+rJAyITuxTCncPJbxWpqfRuWWo4vKm/23m13YQfs/dyCAcp/pnLKq4UCKo/ 2zeyiJbflmNxbPUOW0uaINMiudAp2su689f7I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=ttz6kfP/FjYYewJpjDi05zw+iSb1FAE42Xw+XFNmff0=; b=E7H+XHIjftJ6BFTheXrYKHAo+LnEG5V8Wb9AqarE87v9HeDgtViPTL5q0STbr0KAyv SvjZI+nmZpPE/+pSC5kvESGdm/Lt4L7+d2Cns0Q5XKnxP+xnwx6v5ji8qKDWQldtfW4Z Q3Ulqr5DG3Dj/iWBbSTK13y4iKGxXEIaHzgkJ24TPk03qsG9Z8sC/XCw4NH1W9lRca7w t0Nv6DXSwLw6Ny1kULrw/ZJ5M427nabKRwxRD1FsREhVdDIS+EBS40Uv/RfH6eeGXTj/ NUvrpeBF3p9YCOo379VvSC1bFmS43gaR9Nbpg0yn+jfPzbkg5OttjdPPnil63Tymtu/e RGLQ== X-Gm-Message-State: AOAM532CD4yrc+Qydtgjmt6W6mGvGljP/dN5JYDobIXhMsoBiVFqPXgM VblFwsIhMDuUwiCEkCmDzF3CQR+38ikGhOe3eksHsPAYZJbLSx3c7C5ZyzfWIAx9W2X3eewC8Pz i54kzEiHIbl2RN5nMTmkEnABrqyFEewjGU1j+YTN6CzWRIEPAbUh5D4F9qOLE9qgyuA== X-Google-Smtp-Source: ABdhPJwfFmScUGLlXoSuz2RcQVK7nj2GtjAGSYxfXm8N5rDtbWQc+93pVREHblrv+B6DB0js/KjNsw== X-Received: by 2002:a17:90a:20c:: with SMTP id c12mr12438809pjc.224.1615528713701; Thu, 11 Mar 2021 21:58:33 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 186sm4413173pfb.143.2021.03.11.21.58.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Mar 2021 21:58:33 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Kalesh AP , Somnath Kotur Date: Thu, 11 Mar 2021 21:58:15 -0800 Message-Id: <20210312055819.52789-9-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20210312055819.52789-1-ajit.khaparde@broadcom.com> References: <20210312055819.52789-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH v3 08/12] net/bnxt: log port id in async events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP 1. Used port id in async event logs. 2. Added a debug log in bnxt_hwrm_func_driver_unregister(). Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c | 14 +++++++++----- drivers/net/bnxt/bnxt_hwrm.c | 2 ++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c index b7be3e8e05..20b4f929ba 100644 --- a/drivers/net/bnxt/bnxt_cpr.c +++ b/drivers/net/bnxt/bnxt_cpr.c @@ -100,6 +100,7 @@ void bnxt_handle_async_event(struct bnxt *bp, struct hwrm_async_event_cmpl *async_cmp = (struct hwrm_async_event_cmpl *)cmp; uint16_t event_id = rte_le_to_cpu_16(async_cmp->event_id); + uint16_t port_id = bp->eth_dev->data->port_id; struct bnxt_error_recovery_info *info; uint32_t event_data; @@ -145,11 +146,13 @@ void bnxt_handle_async_event(struct bnxt *bp, if ((event_data & EVENT_DATA1_REASON_CODE_MASK) == EVENT_DATA1_REASON_CODE_FW_EXCEPTION_FATAL) { PMD_DRV_LOG(INFO, - "Firmware fatal reset event received\n"); + "Port %u: Firmware fatal reset event received\n", + port_id); bp->flags |= BNXT_FLAG_FATAL_ERROR; } else { PMD_DRV_LOG(INFO, - "Firmware non-fatal reset event received\n"); + "Port %u: Firmware non-fatal reset event received\n", + port_id); } bp->flags |= BNXT_FLAG_FW_RESET; @@ -163,7 +166,8 @@ void bnxt_handle_async_event(struct bnxt *bp, if (!info) return; - PMD_DRV_LOG(INFO, "Error recovery async event received\n"); + PMD_DRV_LOG(INFO, "Port %u: Error recovery async event received\n", + port_id); event_data = rte_le_to_cpu_32(async_cmp->event_data1) & EVENT_DATA1_FLAGS_MASK; @@ -178,8 +182,8 @@ void bnxt_handle_async_event(struct bnxt *bp, else info->flags &= ~BNXT_FLAG_RECOVERY_ENABLED; - PMD_DRV_LOG(INFO, "recovery enabled(%d), master function(%d)\n", - bnxt_is_recovery_enabled(bp), + PMD_DRV_LOG(INFO, "Port %u: recovery enabled(%d), master function(%d)\n", + port_id, bnxt_is_recovery_enabled(bp), bnxt_is_master_func(bp)); if (bp->flags & BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index fc47950fbd..37fa78e79f 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1336,6 +1336,8 @@ static int bnxt_hwrm_port_phy_cfg(struct bnxt *bp, struct bnxt_link_info *conf) HWRM_CHECK_RESULT(); HWRM_UNLOCK(); + PMD_DRV_LOG(DEBUG, "Port %u: Unregistered with fw\n", + bp->eth_dev->data->port_id); return rc; }