From patchwork Fri Mar 12 05:58:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 88985 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9338FA0547; Fri, 12 Mar 2021 06:59:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB998160876; Fri, 12 Mar 2021 06:58:35 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id D6C1716084B for ; Fri, 12 Mar 2021 06:58:30 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id a8so4900288plp.13 for ; Thu, 11 Mar 2021 21:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=mt414jURal6r8CO4JoJERVY0OXSj/es71JP6sfhSzRc=; b=D4Hi00q4rRTn9cVooiDZg/Fmkz/6KP1A8fDs7ArROoxVghpG0GfnqkBzdYW80LvmB4 sOfiyiSJdoLVIwl9F6xc7E+bAdtpWpYNxBLB4c2YbWgUv1E7/Iyet4SzPE7rUdx/hl7P XdJ+JIeo6rs7EK6A2oyXO/IG9zrWa4pBUYJX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=mt414jURal6r8CO4JoJERVY0OXSj/es71JP6sfhSzRc=; b=Z3OiGWstU5xyoqu6oeGeIwTgU11EgHXEYPwPEZAyDLPwUT/4fV0ZZ95Ud7qgd8Gz1/ A/P6cF2/92iN4CeAmn/LBVpF5y/2GrSYJHTwEmBv0XSj9OvAA5Kd5IrGao6M8jCwc+gE Ina7rmdJ2llUtF7sPdD/5QpN+WFFsu+hd7+EpDlH3DYtlLUJhqLQDrzyY7896kn4we2j 9diLwo+d+wwp8NM7YpBsqrxAQH5rv9zOgknL4fixCfGV4hnacfOP9hBWD9FI5BzobvKj Bvf1lZUnTPzhHtmNNNqdHRJLntG5t0V8h1RhX+DYODahZurr0vsb2yP13p8IHJ1PlIMV eEAA== X-Gm-Message-State: AOAM532cI6KHuRa0MFqRtXcZESkDusm7Y83CfVEWDhyUSZvxN3fOqx63 QFPLiWXae0iqy9GJd6jjN96MkVD1ihbaoKYvh/RsM9lyGIDPmzBwMB2WwuX9uHiFOoyrGPgSRWw vWD4s5RViLreWLi2ncSdhNO/kcavAF7JbNQ9IWffIBijJVo3qDpvuO2fandbpz/NEbw== X-Google-Smtp-Source: ABdhPJwIQWTPuGVEhXnoqcTb0MFDN3Q/a0V2GJZsnKgVvSK+03YDqnRo5d9pR1SKsu0XTZJscSj7Kg== X-Received: by 2002:a17:90a:7182:: with SMTP id i2mr12374635pjk.111.1615528709730; Thu, 11 Mar 2021 21:58:29 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 186sm4413173pfb.143.2021.03.11.21.58.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Mar 2021 21:58:29 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Venkat Duvvuru , stable@dpdk.org, Somnath Kotur , Kalesh AP Date: Thu, 11 Mar 2021 21:58:12 -0800 Message-Id: <20210312055819.52789-6-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20210312055819.52789-1-ajit.khaparde@broadcom.com> References: <20210312055819.52789-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH v3 05/12] net/bnxt: fix queues per VNIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Venkat Duvvuru Update queues per VNIC in single queue mode. bp->rx_num_qs_per_vnic is not initialized in the single queue mode. As a result of this when an interface is reconfigured to single queue mode from an existing multiqueue mode, bp->rx_num_qs_per_vnic is not updated to the value of 1. Hence, the driver will try to access more than one queue resulting in a crash. This patch fixes it by initializing bp->rx_num_qs_per_vnic in the single queue mode as well. Fixes: 36024b2e7fe5 ("net/bnxt: allow dynamic creation of VNIC") Cc: stable@dpdk.org Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index f46b10c1c5..53a9b52a46 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -106,7 +106,6 @@ int bnxt_mq_rx_configure(struct bnxt *bp) pools = RTE_MIN(pools, bp->rx_cp_nr_rings); nb_q_per_grp = bp->rx_cp_nr_rings / pools; - bp->rx_num_qs_per_vnic = nb_q_per_grp; PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n", pools, nb_q_per_grp); start_grp_id = 0; @@ -165,6 +164,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp) } out: + bp->rx_num_qs_per_vnic = nb_q_per_grp; + if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) { struct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf;