From patchwork Fri Mar 12 05:58:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 88983 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC036A0547; Fri, 12 Mar 2021 06:58:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BD7E160866; Fri, 12 Mar 2021 06:58:33 +0100 (CET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id 1AA1E160843 for ; Fri, 12 Mar 2021 06:58:28 +0100 (CET) Received: by mail-pg1-f177.google.com with SMTP id l2so15169406pgb.1 for ; Thu, 11 Mar 2021 21:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=8eb7LaFGY13kbZ5XvX9O9M5eZYQDa1nlmATLacmzIM4=; b=EUQJ4GeNkzW+omUMFVjsdEqouS04kGRfiXXyrAbYQH9Gc1ILpiIEmHXAzCRTDMYOek Ai+ho3zg9BeDrBpWBjfr4jZpwB6ocCY45PSL7SE37MwO7/fBnkwQvhpEDZFKmDiZ1RzZ ywO8T61q0l39+MGxrm8lBH2yvGrlB4mW6shrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=8eb7LaFGY13kbZ5XvX9O9M5eZYQDa1nlmATLacmzIM4=; b=ZkfeD3xusN8kUZ4vVgUkMQIn0dkfMfWQPwCtDvh4bQ23gFVnfNBeo+fFYjDyiFOUk8 kucvogHUwGxsyifZDWEMQDehk+FEyCMC7PQsWeclDEa/bNMwrhK7Rf2yuXfbazl7/MNW dTIHKaHMNa6srvX6iSo+HjFA+m2eNjsxdhjiXjcNemeO42bcabAD+fM/W71gwfQWhkKd HJ+mFL/h6Q03681wGLfatM1Wv9rCUVlI8WRK6c6XkkAy+omwHVMxDlx89obFUNCi3c+v K4yhNmny+gJVSYkeVQ4SNvfvLlMBL/CiWLI9Nln3svAycLc338+0m5GDiYr8endda5eh tclA== X-Gm-Message-State: AOAM531Swtr4s7txg7lE9ywdb+id9QbeIzU1bFWtz6Af3g7IX6YSsb0J QlI6Wz+8T6hToy7MLff6L0C2Dr1eH6D/pWOqIn4MlLFfiQ88fxaG5vozLo0HwOn9xRVY9OFDlRv IeDtKrj+oI1AxZymRqcezUYjjZWOOdE6y32PnrJXLtD9SgR8pD4ULDkJO9I48mxg2QA== X-Google-Smtp-Source: ABdhPJxhGjnvPKd0yIGgWVAlxjbNRVx/LoR2pKLdDDD75QRrmSdEI70mf7aVePSVEcDDHMdkcYykrA== X-Received: by 2002:a63:d40b:: with SMTP id a11mr10144941pgh.192.1615528706727; Thu, 11 Mar 2021 21:58:26 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 186sm4413173pfb.143.2021.03.11.21.58.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Mar 2021 21:58:26 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Kalesh AP , stable@dpdk.org Date: Thu, 11 Mar 2021 21:58:10 -0800 Message-Id: <20210312055819.52789-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20210312055819.52789-1-ajit.khaparde@broadcom.com> References: <20210312055819.52789-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH v3 03/12] net/bnxt: fix VNIC configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP PMD should not set any flags to receive RoCE traffic while configuring the vnic. Since the PMD does not support RoCE some of the flags and code is unused. Clean it up. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 10 ---------- drivers/net/bnxt/bnxt_vnic.h | 2 -- 2 files changed, 12 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index cb8baa8776..5366fe72ca 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2013,12 +2013,6 @@ int bnxt_hwrm_vnic_cfg(struct bnxt *bp, struct bnxt_vnic_info *vnic) if (vnic->bd_stall) req.flags |= rte_cpu_to_le_32(HWRM_VNIC_CFG_INPUT_FLAGS_BD_STALL_MODE); - if (vnic->roce_dual) - req.flags |= rte_cpu_to_le_32( - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_DUAL_VNIC_MODE); - if (vnic->roce_only) - req.flags |= rte_cpu_to_le_32( - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_ONLY_VNIC_MODE); if (vnic->rss_dflt_cr) req.flags |= rte_cpu_to_le_32( HWRM_VNIC_QCFG_OUTPUT_FLAGS_RSS_DFLT_CR_MODE); @@ -2066,10 +2060,6 @@ int bnxt_hwrm_vnic_qcfg(struct bnxt *bp, struct bnxt_vnic_info *vnic, HWRM_VNIC_QCFG_OUTPUT_FLAGS_VLAN_STRIP_MODE; vnic->bd_stall = rte_le_to_cpu_32(resp->flags) & HWRM_VNIC_QCFG_OUTPUT_FLAGS_BD_STALL_MODE; - vnic->roce_dual = rte_le_to_cpu_32(resp->flags) & - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_DUAL_VNIC_MODE; - vnic->roce_only = rte_le_to_cpu_32(resp->flags) & - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_ONLY_VNIC_MODE; vnic->rss_dflt_cr = rte_le_to_cpu_32(resp->flags) & HWRM_VNIC_QCFG_OUTPUT_FLAGS_RSS_DFLT_CR_MODE; diff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h index 917b909284..00a664c8b8 100644 --- a/drivers/net/bnxt/bnxt_vnic.h +++ b/drivers/net/bnxt/bnxt_vnic.h @@ -52,8 +52,6 @@ struct bnxt_vnic_info { bool vlan_strip; bool func_default; bool bd_stall; - bool roce_dual; - bool roce_only; bool rss_dflt_cr; STAILQ_HEAD(, bnxt_filter_info) filter;