| Message ID | 20210303075648.12399-1-wenjun1.wu@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Qi Zhang |
| Headers | show |
| Series | [v2] net/ice: fix wrong RSS hash update | expand |
| Context | Check | Description |
|---|---|---|
| ci/intel-Testing | success | Testing PASS |
| ci/iol-abi-testing | success | Testing PASS |
| ci/iol-testing | success | Testing PASS |
| ci/github-robot | success | github build: passed |
| ci/travis-robot | success | travis build: passed |
| ci/iol-mellanox-Functional | success | Functional Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | success | coding style OK |
Acked-by: Qiming Yang <qiming.yang@intel.com> > -----Original Message----- > From: Wu, Wenjun1 <wenjun1.wu@intel.com> > Sent: 2021年3月3日 15:57 > To: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com> > Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>; stable@dpdk.org > Subject: [PATCH v2] net/ice: fix wrong RSS hash update > > This patch change redundant judgment statements to disable RSS when users > need to disable RSS or RSS hash function configured is not supported. > > Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config") > Cc: stable@dpdk.org > > Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com> > > --- > v2: do pf->rss_hf = 0 when rss_conf->rss_hf == 0 instead of direct removal to > avoid unnecessary judgment. > --- > drivers/net/ice/ice_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index > f43b2e0b2..299162286 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -4461,8 +4461,10 @@ ice_rss_hash_update(struct rte_eth_dev *dev, > if (status) > return status; > > - if (rss_conf->rss_hf == 0) > + if (rss_conf->rss_hf == 0) { > + pf->rss_hf = 0; > return 0; > + } > > /* RSS hash configuration */ > ice_rss_hash_set(pf, rss_conf->rss_hf); > -- > 2.25.1
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index f43b2e0b2..299162286 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -4461,8 +4461,10 @@ ice_rss_hash_update(struct rte_eth_dev *dev, if (status) return status; - if (rss_conf->rss_hf == 0) + if (rss_conf->rss_hf == 0) { + pf->rss_hf = 0; return 0; + } /* RSS hash configuration */ ice_rss_hash_set(pf, rss_conf->rss_hf);
This patch change redundant judgment statements to disable RSS when users need to disable RSS or RSS hash function configured is not supported. Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config") Cc: stable@dpdk.org Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com> --- v2: do pf->rss_hf = 0 when rss_conf->rss_hf == 0 instead of direct removal to avoid unnecessary judgment. --- drivers/net/ice/ice_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)