From patchwork Thu Feb 25 15:29:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 88231 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1CAEA034F; Thu, 25 Feb 2021 16:29:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 056B4160884; Thu, 25 Feb 2021 16:29:26 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id F417A40692 for ; Thu, 25 Feb 2021 16:29:22 +0100 (CET) IronPort-SDR: aDcjRomAwC79mCw2Vp3lksil0q2o8886FFU401Hr9+OyXplgYEIFsGNK3bJnbZFwXvTgJXMjT7 qJc3/dteyaLQ== X-IronPort-AV: E=McAfee;i="6000,8403,9905"; a="249617674" X-IronPort-AV: E=Sophos;i="5.81,206,1610438400"; d="scan'208";a="249617674" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2021 07:29:22 -0800 IronPort-SDR: k8EEi/HenQXNl9quuYoOeUwDv5iqLUVZrSLYtA6VdOJRW7YqLnImsv0COhJ5AxYVqbXNRHhMlM v62mYebx8kRQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,206,1610438400"; d="scan'208";a="367432377" Received: from silpixa00399126.ir.intel.com ([10.237.223.204]) by orsmga006.jf.intel.com with ESMTP; 25 Feb 2021 07:29:21 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, Bruce Richardson Date: Thu, 25 Feb 2021 15:29:03 +0000 Message-Id: <20210225152903.148347-4-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210225152903.148347-1-bruce.richardson@intel.com> References: <20210225152903.148347-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/3] build: limit symbol checks to developer mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The checking of symbols within each library and driver is only of interest to developers, so limit to developer mode only. Signed-off-by: Bruce Richardson --- drivers/meson.build | 20 +++++++++++--------- lib/meson.build | 2 +- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/meson.build b/drivers/meson.build index b26051c21c..54af1f132f 100644 --- a/drivers/meson.build +++ b/drivers/meson.build @@ -170,15 +170,17 @@ foreach subpath:subdirs endif else lk_args = ['-Wl,--version-script=' + version_map] - # on unix systems check the output of the - # check-symbols.sh script, using it as a - # dependency of the .so build - lk_deps += custom_target(lib_name + '.sym_chk', - command: [check_symbols, - version_map, '@INPUT@'], - capture: true, - input: static_lib, - output: lib_name + '.sym_chk') + if developer_mode + # on unix systems check the output of the + # check-symbols.sh script, using it as a + # dependency of the .so build + lk_deps += custom_target(lib_name + '.sym_chk', + command: [check_symbols, + version_map, '@INPUT@'], + capture: true, + input: static_lib, + output: lib_name + '.sym_chk') + endif endif shared_lib = shared_library(lib_name, diff --git a/lib/meson.build b/lib/meson.build index b378050299..d003ad3dfe 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -173,7 +173,7 @@ foreach l:libraries endif lk_deps = [version_map, def_file, mingw_map] - if not is_windows + if developer_mode and not is_windows # on unix systems check the output of the # check-symbols.sh script, using it as a # dependency of the .so build