Message ID | 20210224155553.26893-3-kalesh-anakkur.purayil@broadcom.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Ajit Khaparde |
Headers | show |
Series | bnxt fixes | expand |
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
On 2/24/2021 3:55 PM, Kalesh A P wrote: > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> > > PMD should not set any flags to receive RoCE traffic while > configuring the vnic. Since the PMD does not support RoCE > some of the flags and code is unused. Clean it up. > > Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> > Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com> Hi Ajit, Can you please add 'VNIC' to 'devtools/words-case.txt' to be able to catch errors in patch title for it? Thanks, ferruh
On 3/10/2021 1:13 PM, Ferruh Yigit wrote: > On 2/24/2021 3:55 PM, Kalesh A P wrote: >> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> >> >> PMD should not set any flags to receive RoCE traffic while >> configuring the vnic. Since the PMD does not support RoCE >> some of the flags and code is unused. Clean it up. >> >> Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for >> PF/VF") >> Cc: stable@dpdk.org >> >> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> >> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com> > > Hi Ajit, > > Can you please add 'VNIC' to 'devtools/words-case.txt' to be able to catch > errors in patch title for it? > Also 'Thor' please.
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index cb8baa8..5366fe7 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2013,12 +2013,6 @@ int bnxt_hwrm_vnic_cfg(struct bnxt *bp, struct bnxt_vnic_info *vnic) if (vnic->bd_stall) req.flags |= rte_cpu_to_le_32(HWRM_VNIC_CFG_INPUT_FLAGS_BD_STALL_MODE); - if (vnic->roce_dual) - req.flags |= rte_cpu_to_le_32( - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_DUAL_VNIC_MODE); - if (vnic->roce_only) - req.flags |= rte_cpu_to_le_32( - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_ONLY_VNIC_MODE); if (vnic->rss_dflt_cr) req.flags |= rte_cpu_to_le_32( HWRM_VNIC_QCFG_OUTPUT_FLAGS_RSS_DFLT_CR_MODE); @@ -2066,10 +2060,6 @@ int bnxt_hwrm_vnic_qcfg(struct bnxt *bp, struct bnxt_vnic_info *vnic, HWRM_VNIC_QCFG_OUTPUT_FLAGS_VLAN_STRIP_MODE; vnic->bd_stall = rte_le_to_cpu_32(resp->flags) & HWRM_VNIC_QCFG_OUTPUT_FLAGS_BD_STALL_MODE; - vnic->roce_dual = rte_le_to_cpu_32(resp->flags) & - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_DUAL_VNIC_MODE; - vnic->roce_only = rte_le_to_cpu_32(resp->flags) & - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_ONLY_VNIC_MODE; vnic->rss_dflt_cr = rte_le_to_cpu_32(resp->flags) & HWRM_VNIC_QCFG_OUTPUT_FLAGS_RSS_DFLT_CR_MODE; diff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h index 917b909..00a664c 100644 --- a/drivers/net/bnxt/bnxt_vnic.h +++ b/drivers/net/bnxt/bnxt_vnic.h @@ -52,8 +52,6 @@ struct bnxt_vnic_info { bool vlan_strip; bool func_default; bool bd_stall; - bool roce_dual; - bool roce_only; bool rss_dflt_cr; STAILQ_HEAD(, bnxt_filter_info) filter;