diff mbox series

[v2] app/testpmd: remove unused struct member

Message ID 20210209154026.30984-1-kathleen.capella@arm.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series [v2] app/testpmd: remove unused struct member | expand

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/checkpatch warning coding style issues
ci/iol-mellanox-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Kathleen Capella Feb. 9, 2021, 3:40 p.m. UTC
The tx_queue member of the fwd_lcore struct is unused as it is already
part of the fwd_stream structure. Deleting helps improve code readability.

Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
---
 app/test-pmd/testpmd.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Kathleen Capella Feb. 19, 2021, 5:25 p.m. UTC | #1
The iol-testing warning on this patch seems to be unrelated to the patch. 

On February 9, 2021 10:40 AM, Kathleen Capella wrote
> The tx_queue member of the fwd_lcore struct is unused as it is already part of the fwd_stream 
> structure. Deleting helps improve code readability.

> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> app/test-pmd/testpmd.h | 1 -
> 1 file changed, 1 deletion(-)

> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 5f2316210..f805f1b4d 100644
> --- a/app/test-pmd/testpmd.h
> +++ b/app/test-pmd/testpmd.h
> @@ -247,7 +247,6 @@ struct fwd_lcore {
> 	streamid_t stream_idx;   /**< index of 1st stream in "fwd_streams" */
> 	streamid_t stream_nb;    /**< number of streams in "fwd_streams" */
> 	lcoreid_t  cpuid_idx;    /**< index of logical core in CPU id table */
> -	queueid_t  tx_queue;     /**< TX queue to send forwarded packets */
> 	volatile char stopped;   /**< stop forwarding when set */
> };
 
> --
> 2.17.1
Ferruh Yigit Feb. 19, 2021, 6:50 p.m. UTC | #2
On 2/19/2021 5:25 PM, Kathleen Capella wrote:
> The iol-testing warning on this patch seems to be unrelated to the patch.
> 

Yep, it looks unrelated, spdk build is failing, I tried to trigger build again, 
please check after some time if status changes.

> On February 9, 2021 10:40 AM, Kathleen Capella wrote
>> The tx_queue member of the fwd_lcore struct is unused as it is already part of the fwd_stream
>> structure. Deleting helps improve code readability.
> 
>> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
>> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>> app/test-pmd/testpmd.h | 1 -
>> 1 file changed, 1 deletion(-)
> 
>> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 5f2316210..f805f1b4d 100644
>> --- a/app/test-pmd/testpmd.h
>> +++ b/app/test-pmd/testpmd.h
>> @@ -247,7 +247,6 @@ struct fwd_lcore {
>> 	streamid_t stream_idx;   /**< index of 1st stream in "fwd_streams" */
>> 	streamid_t stream_nb;    /**< number of streams in "fwd_streams" */
>> 	lcoreid_t  cpuid_idx;    /**< index of logical core in CPU id table */
>> -	queueid_t  tx_queue;     /**< TX queue to send forwarded packets */
>> 	volatile char stopped;   /**< stop forwarding when set */
>> };
>   
>> --
>> 2.17.1
>
Ferruh Yigit Feb. 22, 2021, 6:20 p.m. UTC | #3
On 2/9/2021 3:40 PM, Kathleen Capella wrote:
> The tx_queue member of the fwd_lcore struct is unused as it is already
> part of the fwd_stream structure. Deleting helps improve code readability.
> 
> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 5f2316210..f805f1b4d 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -247,7 +247,6 @@  struct fwd_lcore {
 	streamid_t stream_idx;   /**< index of 1st stream in "fwd_streams" */
 	streamid_t stream_nb;    /**< number of streams in "fwd_streams" */
 	lcoreid_t  cpuid_idx;    /**< index of logical core in CPU id table */
-	queueid_t  tx_queue;     /**< TX queue to send forwarded packets */
 	volatile char stopped;   /**< stop forwarding when set */
 };