diff mbox series

[v2,07/37] net/mvpp2: update RSS tables reservation

Message ID 20210122191925.24308-8-lironh@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers show
Series net/mvpp2: misc updates | expand

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Liron Himi Jan. 22, 2021, 7:18 p.m. UTC
From: Yuri Chipchev <yuric@marvell.com>

In kernel-4.14 the pp2 kernel occupied 4 RSS tables
as opposed to 1 RSS table in older version.

Signed-off-by: Yuri Chipchev <yuric@marvell.com>
Reviewed-by: Liron Himi <lironh@marvell.com>
---
 drivers/net/mvpp2/mrvl_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Jan. 26, 2021, 6:02 p.m. UTC | #1
On 1/22/2021 7:18 PM, lironh@marvell.com wrote:
> From: Yuri Chipchev <yuric@marvell.com>
> 
> In kernel-4.14 the pp2 kernel occupied 4 RSS tables
> as opposed to 1 RSS table in older version.
> 
> Signed-off-by: Yuri Chipchev <yuric@marvell.com>
> Reviewed-by: Liron Himi <lironh@marvell.com>
> ---
>   drivers/net/mvpp2/mrvl_ethdev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
> index f7e3f62e3..e4ec343d5 100644
> --- a/drivers/net/mvpp2/mrvl_ethdev.c
> +++ b/drivers/net/mvpp2/mrvl_ethdev.c
> @@ -33,7 +33,7 @@
>   /* bitmask with reserved bpools */
>   #define MRVL_MUSDK_BPOOLS_RESERVED 0x07
>   /* bitmask with reserved kernel RSS tables */
> -#define MRVL_MUSDK_RSS_RESERVED 0x01
> +#define MRVL_MUSDK_RSS_RESERVED 0x0F
>   /* maximum number of available hifs */
>   #define MRVL_MUSDK_HIFS_MAX 9
>   

Will this be compatible with all kernel versions that has 1 RSS table?

Is this related to the kernel version, kernel driver version or musdk version?
Liron Himi Jan. 26, 2021, 6:05 p.m. UTC | #2
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com> 
Sent: Tuesday, 26 January 2021 20:02
To: Liron Himi <lironh@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: dev@dpdk.org; Yuri Chipchev <yuric@marvell.com>
Subject: [EXT] Re: [dpdk-dev] [PATCH v2 07/37] net/mvpp2: update RSS tables reservation

External Email

----------------------------------------------------------------------
On 1/22/2021 7:18 PM, lironh@marvell.com wrote:
> From: Yuri Chipchev <yuric@marvell.com>
> 
> In kernel-4.14 the pp2 kernel occupied 4 RSS tables as opposed to 1 
> RSS table in older version.
> 
> Signed-off-by: Yuri Chipchev <yuric@marvell.com>
> Reviewed-by: Liron Himi <lironh@marvell.com>
> ---
>   drivers/net/mvpp2/mrvl_ethdev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mvpp2/mrvl_ethdev.c 
> b/drivers/net/mvpp2/mrvl_ethdev.c index f7e3f62e3..e4ec343d5 100644
> --- a/drivers/net/mvpp2/mrvl_ethdev.c
> +++ b/drivers/net/mvpp2/mrvl_ethdev.c
> @@ -33,7 +33,7 @@
>   /* bitmask with reserved bpools */
>   #define MRVL_MUSDK_BPOOLS_RESERVED 0x07
>   /* bitmask with reserved kernel RSS tables */ -#define 
> MRVL_MUSDK_RSS_RESERVED 0x01
> +#define MRVL_MUSDK_RSS_RESERVED 0x0F
>   /* maximum number of available hifs */
>   #define MRVL_MUSDK_HIFS_MAX 9
>   

Will this be compatible with all kernel versions that has 1 RSS table?
[L.H.] yes

Is this related to the kernel version, kernel driver version or musdk version?
[L.H.] it is related to the pp2 kernel driver version which bounds to a kernel version
Ferruh Yigit Jan. 27, 2021, 12:41 a.m. UTC | #3
On 1/26/2021 6:05 PM, Liron Himi wrote:
> 
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, 26 January 2021 20:02
> To: Liron Himi <lironh@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org; Yuri Chipchev <yuric@marvell.com>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v2 07/37] net/mvpp2: update RSS tables reservation
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 1/22/2021 7:18 PM, lironh@marvell.com wrote:
>> From: Yuri Chipchev <yuric@marvell.com>
>>
>> In kernel-4.14 the pp2 kernel occupied 4 RSS tables as opposed to 1
>> RSS table in older version.
>>
>> Signed-off-by: Yuri Chipchev <yuric@marvell.com>
>> Reviewed-by: Liron Himi <lironh@marvell.com>
>> ---
>>    drivers/net/mvpp2/mrvl_ethdev.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/mvpp2/mrvl_ethdev.c
>> b/drivers/net/mvpp2/mrvl_ethdev.c index f7e3f62e3..e4ec343d5 100644
>> --- a/drivers/net/mvpp2/mrvl_ethdev.c
>> +++ b/drivers/net/mvpp2/mrvl_ethdev.c
>> @@ -33,7 +33,7 @@
>>    /* bitmask with reserved bpools */
>>    #define MRVL_MUSDK_BPOOLS_RESERVED 0x07
>>    /* bitmask with reserved kernel RSS tables */ -#define
>> MRVL_MUSDK_RSS_RESERVED 0x01
>> +#define MRVL_MUSDK_RSS_RESERVED 0x0F
>>    /* maximum number of available hifs */
>>    #define MRVL_MUSDK_HIFS_MAX 9
>>    
> 
> Will this be compatible with all kernel versions that has 1 RSS table?
> [L.H.] yes
> 

OK to proceed than.

> Is this related to the kernel version, kernel driver version or musdk version?
> [L.H.] it is related to the pp2 kernel driver version which bounds to a kernel version
>
diff mbox series

Patch

diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index f7e3f62e3..e4ec343d5 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -33,7 +33,7 @@ 
 /* bitmask with reserved bpools */
 #define MRVL_MUSDK_BPOOLS_RESERVED 0x07
 /* bitmask with reserved kernel RSS tables */
-#define MRVL_MUSDK_RSS_RESERVED 0x01
+#define MRVL_MUSDK_RSS_RESERVED 0x0F
 /* maximum number of available hifs */
 #define MRVL_MUSDK_HIFS_MAX 9