From patchwork Fri Jan 22 09:01:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Yang X-Patchwork-Id: 87054 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DFA7A0A0A; Fri, 22 Jan 2021 10:04:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85A21140DD3; Fri, 22 Jan 2021 10:04:35 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 5A63D140DD2 for ; Fri, 22 Jan 2021 10:04:34 +0100 (CET) IronPort-SDR: hOIkLv9fPX25qscn6bMuO9RISkSxM8F5o3ODaBda7cfijEvqas/mSeiAfQdvyqsZmKx26c/jOq 6fYeJo5lsJgg== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="240962310" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="240962310" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 01:04:33 -0800 IronPort-SDR: EBfHt2HXkQKE/4A8eV7LfvB3ARxSkZBIRjiGxRy7O/KTYtSclfTmkpb9ofPFaq9jHHvtgNXUQp PQUStAG+mmpw== X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="427910757" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 01:04:31 -0800 From: Steve Yang To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, xiaoyun.li@intel.com, bernard.iremonger@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, stevex.yang@intel.com, qiming.yang@intel.com Date: Fri, 22 Jan 2021 09:01:08 +0000 Message-Id: <20210122090110.50453-2-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210122090110.50453-1-stevex.yang@intel.com> References: <20201223085152.20866-1-stevex.yang@intel.com> <20210122090110.50453-1-stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v3 1/3] ethdev: fix MTU doesn't update when jumbo frame disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The MTU value should be updated to 'max_rx_pkt_len - overhead' no matter if the JUMBO FRAME offload enabled. If not update this MTU, use will get the wrong MTU info via some command. E.g.: 'show port info all' in testpmd tool. Actually, the 'max_rx_pkt_len' has been used for other purposes in many places now, even though the 'max_rx_pkt_len' is expected 'Only used if JUMBO_FRAME enabled'. For examples, 'max_rx_pkt_len' perhaps can be used as the 'rx_ctx.rxmax' in i40e. Fixes: bf0f90d92d30 ("ethdev: fix max Rx packet length check") Signed-off-by: Steve Yang --- lib/librte_ethdev/rte_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index daf5f24f7e..42857e3b67 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -1421,10 +1421,6 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, ret = -EINVAL; goto rollback; } - - /* Scale the MTU size to adapt max_rx_pkt_len */ - dev->data->mtu = dev->data->dev_conf.rxmode.max_rx_pkt_len - - overhead_len; } else { uint16_t pktlen = dev_conf->rxmode.max_rx_pkt_len; if (pktlen < RTE_ETHER_MIN_MTU + overhead_len || @@ -1434,6 +1430,10 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, RTE_ETHER_MTU + overhead_len; } + /* Scale the MTU size to adapt max_rx_pkt_len */ + dev->data->mtu = dev->data->dev_conf.rxmode.max_rx_pkt_len - + overhead_len; + /* * If LRO is enabled, check that the maximum aggregated packet * size is supported by the configured device.