From patchwork Wed Jan 20 16:40:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 86999 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 844DDA0A05; Wed, 20 Jan 2021 17:40:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2347B140DF8; Wed, 20 Jan 2021 17:40:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 57EBA140DEF for ; Wed, 20 Jan 2021 17:40:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611160837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RC9mQBQ/LfYvuw6ayANVOfS0tvxaA1ApgbTaNsU5sOI=; b=YeMrDSsaGyQTwvSEBpD6lbKZOmzvIwxR0u5icx0QaZ2pYCLSWhf+g8g9Zy6CfxU0P4sIKu CRN5Mc7vPl9CS90B+/R6mHS2v0o+RdPQa02ARfTSHMKuT5nMI0QCCoP8kDTQc7A/tMoyxV tPFp12XFsxtmAGi+F9ZPom81tE+Rbcc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-34B8fjv3P-a2kKjmL6oW8g-1; Wed, 20 Jan 2021 11:40:34 -0500 X-MC-Unique: 34B8fjv3P-a2kKjmL6oW8g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA6291005504; Wed, 20 Jan 2021 16:40:32 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.193.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7C495D9C2; Wed, 20 Jan 2021 16:40:28 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, ferruh.yigit@intel.com, Beilei Xing , Jeff Guo , Wenzhuo Lu , Leyi Rong , Bruce Richardson Date: Wed, 20 Jan 2021 17:40:16 +0100 Message-Id: <20210120164016.26745-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] net/i40e: disable AVX512 for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" AVX512 does not seem supported with FC32 and Windows mingw: FAILED: drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj x86_64-w64-mingw32-gcc -Idrivers/net/i40e/libi40e_avx512_lib.a.p -Idrivers/net/i40e -I../../dpdk/drivers/net/i40e -Idrivers/net/i40e/base -I../../dpdk/drivers/net/i40e/base -Ilib/librte_ethdev -I../../dpdk/lib/librte_ethdev -I. -I../../dpdk -Iconfig -I../../dpdk/config -Ilib/librte_eal/include -I../../dpdk/lib/librte_eal/include -Ilib/librte_eal/windows/include -I../../dpdk/lib/librte_eal/windows/include -Ilib/librte_eal/x86/include -I../../dpdk/lib/librte_eal/x86/include -Ilib/librte_eal/common -I../../dpdk/lib/librte_eal/common -Ilib/librte_eal -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs -I../../dpdk/lib/librte_kvargs -Ilib/librte_net -I../../dpdk/lib/librte_net -Ilib/librte_mbuf -I../../dpdk/lib/librte_mbuf -Ilib/librte_mempool -I../../dpdk/lib/librte_mempool -Ilib/librte_ring -I../../dpdk/lib/librte_ring -Ilib/librte_meter -I../../dpdk/lib/librte_meter -I../../dpdk/lib/librte_metrics -Ilib/librte_telemetry -I../../dpdk/lib/librte_telemetry -Ilib/librte_hash -I../../dpdk/lib/librte_hash -Ilib/librte_rcu -I../../dpdk/lib/librte_rcu -I/home/dmarchan/intel-ipsec-mb/install/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -D_WIN32_WINNT=0x0A00 -D__USE_MINGW_ANSI_STDIO -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DPF_DRIVER -DVF_DRIVER -DINTEGRATED_VF -DX722_A0_SUPPORT -DCC_AVX2_SUPPORT -DCC_AVX512_SUPPORT -mavx512f -mavx512bw -march=skylake-avx512 -MD -MQ drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj -MF drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj.d -o drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj -c ../../dpdk/drivers/net/i40e/i40e_rxtx_vec_avx512.c {standard input}: Assembler messages: {standard input}:112: Error: invalid register for .seh_savexmm {standard input}:114: Error: invalid register for .seh_savexmm {standard input}:116: Error: invalid register for .seh_savexmm {standard input}:118: Error: invalid register for .seh_savexmm ... Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path") Signed-off-by: David Marchand --- There is probably better to do rather than disabling AVX512 globally for Windows but since I saw no patch fixing this, here it is. --- drivers/net/i40e/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build index c0acdf4fd4..c9a1a50407 100644 --- a/drivers/net/i40e/meson.build +++ b/drivers/net/i40e/meson.build @@ -54,7 +54,7 @@ if arch_subdir == 'x86' cc.has_argument('-mavx512f') and cc.has_argument('-mavx512bw')) - if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true + if not is_windows and (i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true) cflags += ['-DCC_AVX512_SUPPORT'] avx512_args = [cflags, '-mavx512f', '-mavx512bw'] if cc.has_argument('-march=skylake-avx512')