From patchwork Tue Jan 19 10:43:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ding, Xuan" X-Patchwork-Id: 86885 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 983BEA0A03; Tue, 19 Jan 2021 11:43:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FFE6140D9F; Tue, 19 Jan 2021 11:43:28 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 19F62140D4E; Tue, 19 Jan 2021 11:43:25 +0100 (CET) IronPort-SDR: 9jtKJILxTFx1lCGVo14zBXm4fAGyjorx8upHthHWJnZuIlBHGS9JYNkGGgFeTsGN3/Ikucv65l WvHLhTihO+dQ== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="176336164" X-IronPort-AV: E=Sophos;i="5.79,358,1602572400"; d="scan'208";a="176336164" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2021 02:43:25 -0800 IronPort-SDR: Xj9NkvOOcoaxsQ4SfheK97JvLgZw3RtEXdTVWUwTf3i4UDmt7qeCs6MJXeRxPSD8pTkWSHrE6e wFqP4JTGRx/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,358,1602572400"; d="scan'208";a="350472240" Received: from dpdk-xuanding-dev2.sh.intel.com ([10.67.119.124]) by orsmga003.jf.intel.com with ESMTP; 19 Jan 2021 02:43:23 -0800 From: Xuan Ding To: qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, Xuan Ding , stable@dpdk.org Date: Tue, 19 Jan 2021 10:43:20 +0000 Message-Id: <20210119104320.7200-1-xuan.ding@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/ice: fix symmetric rule creating X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Do not allow to create symmetric rule only if l3/l4 src/dst_only is set. Fixes: 38d632cbdc88("net/ice: refactor PF RSS") Cc: stable@dpdk.org Signed-off-by: Xuan Ding --- drivers/net/ice/ice_hash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 2d23c8dd50..85213bd83a 100644 --- a/drivers/net/ice/ice_hash.c +++ b/drivers/net/ice/ice_hash.c @@ -865,8 +865,8 @@ ice_any_invalid_rss_type(enum rte_eth_hash_function rss_func, * hash function. */ if (rss_func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) { - if (rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY | - ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY)) + if (!(rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY | + ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY))) return true; }