| Message ID | 20210115125250.22416-1-david.hunt@intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | [v1] power: vm power manager should respect core mask | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-testing | fail | Testing issues |
| ci/iol-abi-testing | success | Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/intel-Testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-mellanox-Functional | success | Functional Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/checkpatch | success | coding style OK |
15/01/2021 13:52, David Hunt: > when vm_power_manager is started, it takes over power management on > all cores. This should be limited to cores defined in the core mask. > > When initialising, if a core is not on the coremask, skip it. Applies > to both initialisation and exit. > > Signed-off-by: David Hunt <david.hunt@intel.com> Applied with title "examples/vm_power: respect core mask", thanks
diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c index a26315051..9dca6f686 100644 --- a/examples/vm_power_manager/channel_manager.c +++ b/examples/vm_power_manager/channel_manager.c @@ -455,6 +455,9 @@ add_all_channels(const char *vm_name) CHANNEL_MGR_SOCKET_PATH, dir->d_name); continue; } + if (rte_lcore_index(channel_num) == -1) + continue; + /* if channel has not been added previously */ if (channel_exists(vm_info, channel_num)) continue; @@ -512,6 +515,8 @@ add_channels(const char *vm_name, unsigned *channel_list, } for (i = 0; i < len_channel_list; i++) { + if (rte_lcore_index(i) == -1) + continue; if (channel_list[i] >= RTE_MAX_LCORE) { RTE_LOG(INFO, CHANNEL_MANAGER, "Channel(%u) is out of range " @@ -574,6 +579,9 @@ add_host_channels(void) } for (i = 0; i < ci->core_count; i++) { + if (rte_lcore_index(i) == -1) + continue; + if (ci->cd[i].global_enabled_cpus == 0) continue; diff --git a/examples/vm_power_manager/power_manager.c b/examples/vm_power_manager/power_manager.c index c5cf6bffa..739372d9b 100644 --- a/examples/vm_power_manager/power_manager.c +++ b/examples/vm_power_manager/power_manager.c @@ -96,6 +96,9 @@ power_manager_init(void) max_core_num = ci->core_count; for (i = 0; i < max_core_num; i++) { + if (rte_lcore_index(i) == -1) + continue; + if (ci->cd[i].global_enabled_cpus) { if (rte_power_init(i) < 0) RTE_LOG(ERR, POWER_MANAGER, @@ -170,6 +173,9 @@ power_manager_exit(void) max_core_num = ci->core_count; for (i = 0; i < max_core_num; i++) { + if (rte_lcore_index(i) == -1) + continue; + if (ci->cd[i].global_enabled_cpus) { if (rte_power_exit(i) < 0) { RTE_LOG(ERR, POWER_MANAGER, "Unable to shutdown power manager "
when vm_power_manager is started, it takes over power management on all cores. This should be limited to cores defined in the core mask. When initialising, if a core is not on the coremask, skip it. Applies to both initialisation and exit. Signed-off-by: David Hunt <david.hunt@intel.com> --- examples/vm_power_manager/channel_manager.c | 8 ++++++++ examples/vm_power_manager/power_manager.c | 6 ++++++ 2 files changed, 14 insertions(+)