| Message ID | 20210114165855.31863-1-stephen@networkplumber.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | test: add missing ticketlock test to fast tests | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-testing | success | Testing PASS |
| ci/iol-testing | success | Testing PASS |
| ci/iol-abi-testing | success | Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-mellanox-Functional | success | Functional Testing PASS |
| ci/iol-mellanox-Functional | success | Functional Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/intel-Testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/checkpatch | success | coding style OK |
14/01/2021 17:58, Stephen Hemminger:
> The ticketlock test is fast and should be run all the time.
I think it was not added because it includes a perf test.
Cc'ing more people for comments.
On Sun, 17 Jan 2021 18:57:56 +0100 Thomas Monjalon <thomas@monjalon.net> wrote: > 14/01/2021 17:58, Stephen Hemminger: > > The ticketlock test is fast and should be run all the time. > > I think it was not added because it includes a perf test. > Cc'ing more people for comments. > > Other lock code (rwlock is very similar and in the fast tests).
Stephen Hemminger <stephen@networkplumber.org> writes: > On Sun, 17 Jan 2021 18:57:56 +0100 > Thomas Monjalon <thomas@monjalon.net> wrote: > >> 14/01/2021 17:58, Stephen Hemminger: >> > The ticketlock test is fast and should be run all the time. >> >> I think it was not added because it includes a perf test. >> Cc'ing more people for comments. >> >> > > Other lock code (rwlock is very similar and in the fast tests). I agree, it should be included. I did some digging and seems it wasn't ever part of this set of lists, but could have been all along. As for execution time, here's a run from the 0-day bot: https://github.com/ovsrobot/dpdk/actions/runs/486047432 17m seems to be in the normal range. Acked-by: Aaron Conole <aconole@redhat.com> Thanks, Stephen!
18/01/2021 14:29, Aaron Conole: > Stephen Hemminger <stephen@networkplumber.org> writes: > > > On Sun, 17 Jan 2021 18:57:56 +0100 > > Thomas Monjalon <thomas@monjalon.net> wrote: > > > >> 14/01/2021 17:58, Stephen Hemminger: > >> > The ticketlock test is fast and should be run all the time. > >> > >> I think it was not added because it includes a perf test. > >> Cc'ing more people for comments. > >> > >> > > > > Other lock code (rwlock is very similar and in the fast tests). > > I agree, it should be included. I did some digging and seems it wasn't > ever part of this set of lists, but could have been all along. As for > execution time, here's a run from the 0-day bot: > > https://github.com/ovsrobot/dpdk/actions/runs/486047432 > > 17m seems to be in the normal range. > > Acked-by: Aaron Conole <aconole@redhat.com> > > Thanks, Stephen! Applied, thanks
diff --git a/app/test/meson.build b/app/test/meson.build index 94fd39fecb82..90c4d05814f1 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -245,6 +245,7 @@ fast_tests = [ ['string_autotest', true], ['table_autotest', true], ['tailq_autotest', true], + ['ticketlock_autotest', true], ['timer_autotest', false], ['user_delay_us', true], ['version_autotest', true],
The ticketlock test is fast and should be run all the time. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- app/test/meson.build | 1 + 1 file changed, 1 insertion(+)