Message ID | 20210114110606.21142-5-bruce.richardson@intel.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | David Marchand |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DF44A0A02; Thu, 14 Jan 2021 12:06:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF8BE141164; Thu, 14 Jan 2021 12:06:25 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id A7BA214114D; Thu, 14 Jan 2021 12:06:19 +0100 (CET) IronPort-SDR: 2IQXgauvys1QQWhReIGbJssreLk4nNPEbIfqP/7nogFmqpvGDC6nEBXsFtiZ54rAuRvvCFNUfz GI6n7scy6L4g== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498502" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498502" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:18 -0800 IronPort-SDR: zTuXM13todfTl5cxnSbql/znnl2U079ZC8h2DSJQB2Thfa1q64w+gI3t/jKL9equn7h/2wzl9P oyVbcSfRSb1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139806" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:17 -0800 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:50 +0000 Message-Id: <20210114110606.21142-5-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 04/20] ring: fix missing includes for c11 model header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
ensure headers have correct includes
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Bruce Richardson
Jan. 14, 2021, 11:05 a.m. UTC
Add in the missing includes into the header file for c11 memory model,
so it can be compiled up independently of the other headers.
Fixes: 39368ebfc606 ("ring: introduce C11 memory model barrier option")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/librte_ring/rte_ring_c11_mem.h | 4 ++++
1 file changed, 4 insertions(+)
Comments
On Thu, Jan 14, 2021 at 12:07 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > > Add in the missing includes into the header file for c11 memory model, > so it can be compiled up independently of the other headers. > > Fixes: 39368ebfc606 ("ring: introduce C11 memory model barrier option") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > --- > lib/librte_ring/rte_ring_c11_mem.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_ring/rte_ring_c11_mem.h b/lib/librte_ring/rte_ring_c11_mem.h > index 0fb73a3371..12caf06a31 100644 > --- a/lib/librte_ring/rte_ring_c11_mem.h > +++ b/lib/librte_ring/rte_ring_c11_mem.h > @@ -10,6 +10,10 @@ > #ifndef _RTE_RING_C11_MEM_H_ > #define _RTE_RING_C11_MEM_H_ > > +#include <stdint.h> > +#include <rte_common.h> > +#include <rte_ring_core.h> > + This header is never directly included, like rte_ring_generic.h. I'd rather flag it as not being checked.
> > On Thu, Jan 14, 2021 at 12:07 PM Bruce Richardson > <bruce.richardson@intel.com> wrote: > > > > Add in the missing includes into the header file for c11 memory model, > > so it can be compiled up independently of the other headers. > > > > Fixes: 39368ebfc606 ("ring: introduce C11 memory model barrier option") > > Cc: stable@dpdk.org > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > --- > > lib/librte_ring/rte_ring_c11_mem.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/lib/librte_ring/rte_ring_c11_mem.h b/lib/librte_ring/rte_ring_c11_mem.h > > index 0fb73a3371..12caf06a31 100644 > > --- a/lib/librte_ring/rte_ring_c11_mem.h > > +++ b/lib/librte_ring/rte_ring_c11_mem.h > > @@ -10,6 +10,10 @@ > > #ifndef _RTE_RING_C11_MEM_H_ > > #define _RTE_RING_C11_MEM_H_ > > > > +#include <stdint.h> > > +#include <rte_common.h> > > +#include <rte_ring_core.h> > > + > > This header is never directly included, like rte_ring_generic.h. > I'd rather flag it as not being checked. Yep, it is sort of 'internal' header that we need to keep public, because of inlined ring enqueue/dequeue functions. > > > -- > David Marchand
diff --git a/lib/librte_ring/rte_ring_c11_mem.h b/lib/librte_ring/rte_ring_c11_mem.h index 0fb73a3371..12caf06a31 100644 --- a/lib/librte_ring/rte_ring_c11_mem.h +++ b/lib/librte_ring/rte_ring_c11_mem.h @@ -10,6 +10,10 @@ #ifndef _RTE_RING_C11_MEM_H_ #define _RTE_RING_C11_MEM_H_ +#include <stdint.h> +#include <rte_common.h> +#include <rte_ring_core.h> + static __rte_always_inline void update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new_val, uint32_t single, uint32_t enqueue)