| Message ID | 20201222135658.53916-2-maxime.coquelin@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Maxime Coquelin |
| Headers | show |
| Series | vhost: make virtqueue cache-friendly | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
> -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: Tuesday, December 22, 2020 9:57 PM > To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; amorenoz@redhat.com > Cc: Maxime Coquelin <maxime.coquelin@redhat.com> > Subject: [PATCH 1/3] vhost: remove unused Vhost virtqueue field > > This patch removes the "backend" field of the > vhost_virtqueue struct, which is not used by the > library. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > --- > lib/librte_vhost/vhost.c | 2 -- > lib/librte_vhost/vhost.h | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c > index b83cf639eb..4e5df862aa 100644 > --- a/lib/librte_vhost/vhost.c > +++ b/lib/librte_vhost/vhost.c > @@ -557,8 +557,6 @@ init_vring_queue(struct virtio_net *dev, uint32_t > vring_idx) > vq->notif_enable = VIRTIO_UNINITIALIZED_NOTIF; > > vhost_user_iotlb_init(dev, vring_idx); > - /* Backends are set to -1 indicating an inactive device. */ > - vq->backend = -1; > } > > static void > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index 361c9f79b3..d132e4ae54 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -143,8 +143,6 @@ struct vhost_virtqueue { > #define VIRTIO_INVALID_EVENTFD (-1) > #define VIRTIO_UNINITIALIZED_EVENTFD (-2) > > - /* Backend value to determine if device should started/stopped */ > - int backend; > int enabled; > int access_ok; > int ready; > -- > 2.29.2 Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index b83cf639eb..4e5df862aa 100644 --- a/lib/librte_vhost/vhost.c +++ b/lib/librte_vhost/vhost.c @@ -557,8 +557,6 @@ init_vring_queue(struct virtio_net *dev, uint32_t vring_idx) vq->notif_enable = VIRTIO_UNINITIALIZED_NOTIF; vhost_user_iotlb_init(dev, vring_idx); - /* Backends are set to -1 indicating an inactive device. */ - vq->backend = -1; } static void diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 361c9f79b3..d132e4ae54 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/librte_vhost/vhost.h @@ -143,8 +143,6 @@ struct vhost_virtqueue { #define VIRTIO_INVALID_EVENTFD (-1) #define VIRTIO_UNINITIALIZED_EVENTFD (-2) - /* Backend value to determine if device should started/stopped */ - int backend; int enabled; int access_ok; int ready;
This patch removes the "backend" field of the vhost_virtqueue struct, which is not used by the library. Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> --- lib/librte_vhost/vhost.c | 2 -- lib/librte_vhost/vhost.h | 2 -- 2 files changed, 4 deletions(-)