From patchwork Tue Dec 8 20:11:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 84826 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB96CA09E9; Tue, 8 Dec 2020 21:13:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2FB6C9D4; Tue, 8 Dec 2020 21:11:54 +0100 (CET) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 4E60CC99C for ; Tue, 8 Dec 2020 21:11:48 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id b26so14951021pfi.3 for ; Tue, 08 Dec 2020 12:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=yquH+v8hNY0Kbdao8sFkZx3LQpYXrw9D88JN5z5+r2s=; b=KzNeouYNWNWTZHbxfui2Yh3RYJCLFpGkkk/MmQkLwmzh1llF5hGOyax8DfIT1rT6Z7 nslDdA1YPHSL1i8wuKHmmbqdEUb87TMNnwcnZZLBYN6/wyq25lMwQeA8VQAth+yDXr7t TIFDQA/EZQ3afFIkpHgO/E7AhOutKC7+iKj7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=yquH+v8hNY0Kbdao8sFkZx3LQpYXrw9D88JN5z5+r2s=; b=niurHMuGp+XoxqTLmBalUEszmC1MJCuPA7yOlnS5Y8azkud/+OHbaNHu75YQtwraV+ 4xFVfPP+ZOPOv2jzKFnsB/phJJWXt/8OirZC79Zuk9DTNTBew90z1p1D9RPBw5ceorAa hmaqhpXNxWI2mmERruVCLNoPk7+8l+77nmNHKQgR2qmUHp3vv3BTXVCeo8ps0GlqTFQw RZ9A42Uj1xaxkrqVe6nLsAKoajPL4YVuv5enL7lm0BfQ5ErhZvKWlKzcxEoiJiVfpWih F8hcUoRTIMs8JFkb8fkogXRd/u1nplvbKZfxHdQ3/KWhsTKUIZphgob2iVZkMlcZiTry w2cQ== X-Gm-Message-State: AOAM532D3ntw0kZlWY9M92JEGZ4LbfHeDtvuq8s2HR1nDRnseA5iBL/L zMwHDGzRfcB0GcHEjY31VknKUn5FfsJPTLCjH2Z3ZWblDTGxn046k0tVroLRcjQXDebsGHs2hc9 rPsIGREgqEejY3dqAMNfCkLib2/k4x83CXf/JXMiicUBduAM3/yKCVWpeatSVJ+ZnMg== X-Google-Smtp-Source: ABdhPJyH+ZpWGK0hPPIkVkSOMMcsuEi5JPy2+UBAEOOl99CMwesKogbcPrhd9qvFPV5/U44y5wDLfg== X-Received: by 2002:a65:5b8e:: with SMTP id i14mr24113042pgr.198.1607458307160; Tue, 08 Dec 2020 12:11:47 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x10sm5729187pfc.157.2020.12.08.12.11.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Dec 2020 12:11:46 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP , stable@dpdk.org, Somnath Kotur Date: Tue, 8 Dec 2020 12:11:23 -0800 Message-Id: <20201208201134.47844-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20201208201134.47844-1-ajit.khaparde@broadcom.com> References: <20201208201134.47844-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] [PATCH 06/17] net/bnxt: fix to return error when fw command fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP In bnxt_reta_update_op() and bnxt_rss_hash_update_op(), driver does not propagate the error back to the application when the fw command fails. Fixes: 378ab645bb0b ("net/bnxt: fix RSS RETA indirection table ops") Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 8047b0b5d..33358779b 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1843,8 +1843,8 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev, } } - bnxt_hwrm_vnic_rss_cfg(bp, vnic); - return 0; + rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + return rc; } static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev, @@ -1949,8 +1949,8 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev, memcpy(vnic->rss_hash_key, rss_conf->rss_key, rss_conf->rss_key_len); rss_config: - bnxt_hwrm_vnic_rss_cfg(bp, vnic); - return 0; + rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + return rc; } static int bnxt_rss_hash_conf_get_op(struct rte_eth_dev *eth_dev,