From patchwork Thu Nov 26 14:20:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Matz X-Patchwork-Id: 84584 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B79A8A052A; Thu, 26 Nov 2020 15:21:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7FF96C99C; Thu, 26 Nov 2020 15:20:51 +0100 (CET) Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id E0DA1C98A; Thu, 26 Nov 2020 15:20:49 +0100 (CET) Received: from glumotte.dev.6wind.com. (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id ABC2549770B; Thu, 26 Nov 2020 15:20:49 +0100 (CET) From: Olivier Matz To: dev@dpdk.org Cc: Bruce Richardson , Harry van Haaren , Keith Wiles , Luca Boccassi , stable@dpdk.org Date: Thu, 26 Nov 2020 15:20:42 +0100 Message-Id: <20201126142042.24741-1-olivier.matz@6wind.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] app: fix plugin load on static builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When dpdk is compiled as static libraries, it is not possible to load a plugin from an application. We get the following error: EAL: librte_pmd_xxxx.so: undefined symbol: per_lcore__rte_errno This happens because the dpdk symbols are not exported. Add them to the dynamic symbol table by using '-Wl,--export-dynamic'. This option was previously present when compiled with Makefiles, it was introduced in commit f9a08f650211 ("eal: add support for shared object drivers") Fixes: 16ade738fd0d ("app/testpmd: build with meson") Fixes: 89f0711f9ddf ("examples: build some samples with meson") Cc: stable@dpdk.org Signed-off-by: Olivier Matz Acked-by: Bruce Richardson --- Hi, Maybe the patch can be improved: I suppose that --export-dynamic should only be added in case we are linking in static mode. Any help about how to do that is welcome. There is probably a better place to define the default ldflags for all applications (to factorize between app and example). Also, should this flag be advertised in pkg-config? Thanks, Olivier app/meson.build | 3 +++ examples/meson.build | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/meson.build b/app/meson.build index eb74f215a3..92479c7729 100644 --- a/app/meson.build +++ b/app/meson.build @@ -25,6 +25,7 @@ apps = [ lib_execinfo = cc.find_library('execinfo', required: false) default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API'] +default_ldflags = ['-Wl,--export-dynamic'] foreach app:apps build = true @@ -32,6 +33,7 @@ foreach app:apps sources = [] includes = [] cflags = default_cflags + ldflags = default_ldflags objs = [] # other object files to link against, used e.g. for # instruction-set optimized versions of code @@ -58,6 +60,7 @@ foreach app:apps executable('dpdk-' + name, sources, c_args: cflags, + link_args: ldflags, link_whole: link_libs, dependencies: dep_objs, install_rpath: join_paths(get_option('prefix'), diff --git a/examples/meson.build b/examples/meson.build index 46ec80919e..def4540e8f 100644 --- a/examples/meson.build +++ b/examples/meson.build @@ -63,6 +63,7 @@ default_cflags = machine_args if cc.has_argument('-Wno-format-truncation') default_cflags += '-Wno-format-truncation' endif +default_ldflags = ['-Wl,--export-dynamic'] + dpdk_extra_ldflags foreach example: examples name = example.split('/')[-1] @@ -70,6 +71,7 @@ foreach example: examples sources = [] allow_experimental_apis = false cflags = default_cflags + ldflags = default_ldflags ext_deps = [execinfo] includes = [include_directories(example)] @@ -91,7 +93,7 @@ foreach example: examples executable('dpdk-' + name, sources, include_directories: includes, link_whole: link_whole_libs, - link_args: dpdk_extra_ldflags, + link_args: ldflags, c_args: cflags, dependencies: dep_objs) elif not allow_skips