From patchwork Fri Nov 13 11:44:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 84132 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D89CBA09DE; Fri, 13 Nov 2020 12:44:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5B1A4CA6; Fri, 13 Nov 2020 12:44:10 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8953537B4 for ; Fri, 13 Nov 2020 12:44:07 +0100 (CET) IronPort-SDR: upB+8fHoQX9vOiO+VxnAwsCAmg5MQ52BWROQb1dcIwCVcsBQ69+wpnfrJMxjWP9f8brO7O2DrC 7u3G3A4MXDrQ== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="169677494" X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="169677494" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2020 03:44:04 -0800 IronPort-SDR: 5N28JgipTBZmVpniRPlzskBjQQYVYLW3rGuDdzSsctnQKNeMnWlIp//Un3m14/xY9p/Qsszsg7 KdwxZvjfk7Dg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="323969481" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga003.jf.intel.com with ESMTP; 13 Nov 2020 03:44:02 -0800 From: Ferruh Yigit To: Wenzhuo Lu , Beilei Xing , Bernard Iremonger Cc: Ferruh Yigit , dev@dpdk.org, Qi Zhang , Steve Yang , Thomas Monjalon , Andrew Rybchenko , Konstantin Ananyev , Olivier Matz , Lance Richardson Date: Fri, 13 Nov 2020 11:44:00 +0000 Message-Id: <20201113114400.3356527-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201105180942.2938152-1-ferruh.yigit@intel.com> References: <20201105180942.2938152-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] app/testpmd: fix MTU after device configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). This is mistake because for the PMDs that has frame size bigger than "RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 bytes), the MTU becomes less than 1500, causing a valid frame with 1500 bytes payload to be dropped. Since 'rte_eth_dev_set_mtu()' works as expected, it is called after 'rte_eth_dev_configure()' to fix the MTU. It may look redundant to set MTU after 'rte_eth_dev_configure()', both with default values, but it is not, the resulting MTU config can be different in the device based on frame overhead of the PMD. And instead of setting the MTU to default value, it is first get via 'rte_eth_dev_get_mtu()' and set again, this is to cover cases MTU changed from testpmd command line. 'rte_eth_dev_set_mtu()', '-ENOTSUP' error is ignored to prevent irrelevant warning messages for the virtual PMDs. Signed-off-by: Ferruh Yigit Reviewed-by: Qi Zhang Acked-by: Andrew Rybchenko Tested-by: Igor Romanov --- Cc: Steve Yang Cc: Thomas Monjalon Cc: Andrew Rybchenko Cc: Konstantin Ananyev Cc: Olivier Matz Cc: Lance Richardson --- app/test-pmd/testpmd.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 33fc0fddf5..48e9647fc7 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2537,6 +2537,8 @@ start_port(portid_t pid) } if (port->need_reconfig > 0) { + uint16_t mtu = RTE_ETHER_MTU; + port->need_reconfig = 0; if (flow_isolate_all) { @@ -2570,6 +2572,23 @@ start_port(portid_t pid) port->need_reconfig = 1; return -1; } + + /* + * Workaround for rte_eth_dev_configure(), max_rx_pkt_len + * set MTU wrong for the PMDs that have frame overhead + * bigger than RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN. + * For a PMD that has 26 bytes overhead, rte_eth_dev_configure() + * can set MTU to max 1492, not to expected 1500 bytes. + * Using rte_eth_dev_set_mtu() to be able to set MTU correctly, + * default MTU value is 1500. + */ + diag = rte_eth_dev_get_mtu(pi, &mtu); + if (diag) + printf("Failed to get MTU for port %d\n", pi); + diag = rte_eth_dev_set_mtu(pi, mtu); + if (diag != 0 && diag != -ENOTSUP) + printf("Failed to set MTU to %u for port %d\n", + mtu, pi); } if (port->need_reconfig_queues > 0) { port->need_reconfig_queues = 0;