From patchwork Tue Nov 10 17:54:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 83914 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48FF2A04DD; Tue, 10 Nov 2020 18:55:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 070482B93; Tue, 10 Nov 2020 18:55:13 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 400F9F64; Tue, 10 Nov 2020 18:55:09 +0100 (CET) IronPort-SDR: qDwPtkTqEJE+6Jjb67+FErqNdVW59yS5Z05MQwMIqe5F1kqHeqwtFl3Wu/Fd37MScErMJQUx23 BXqhkjViS9WQ== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="187988682" X-IronPort-AV: E=Sophos;i="5.77,467,1596524400"; d="scan'208";a="187988682" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:55:03 -0800 IronPort-SDR: ygGTI8m9PwV/CSTJJWJwb0KtvmKHC5miQpDshuJY/tYFu3vlj3mgCsrPbBDfQ9kScpR228LH2n YhP04nzAi35w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,467,1596524400"; d="scan'208";a="531320234" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by fmsmga005.fm.intel.com with ESMTP; 10 Nov 2020 09:54:59 -0800 From: Ferruh Yigit To: Beilei Xing , Jeff Guo , Helin Zhang , Jingjing Wu , Remy Horton , Jijiang Liu , Jing Chen , Heqing Zhu Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org, Luca Boccassi , David Marchand Date: Tue, 10 Nov 2020 17:54:57 +0000 Message-Id: <20201110175457.734922-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201110134852.3959367-1-ferruh.yigit@intel.com> References: <20201110134852.3959367-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] net/i40e: fix build for log format specifier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Build error: i40e_common.c: In function "i40e_parse_discover_capabilities": ../drivers/net/i40e/base/../i40e_logs.h:43:50: error: format "%llX" expects argument of type "long long unsigned int", but argument 7 has type "u64" {aka "long unsigned int" [-Werror=format=] 43 | rte_log(RTE_LOG_ ## level, i40e_logtype_driver, "%s(): " fmt, \ | ^~~~~~~~ .../i40e_osdep.h:87:3: note: in expansion of macro "PMD_DRV_LOG_RAW" 87 | PMD_DRV_LOG_RAW(DEBUG, "i40e %02x.%x " s, \ | ^~~~~~~~~~~~~~~ .../base/i40e_common.c:4100:4: note: in expansion of macro "i40e_debug" 4100 | i40e_debug(hw, I40E_DEBUG_INIT, | ^~~~~~~~~~ There are multiple build error because of same reason, all fixed. Using 'PRIX64' to fix the build error. Fixes: 889bc9f0cd3a ("i40e/base: unify the capability function") Fixes: 9b1041574cd4 ("i40e/base: enhance polling of NVM semaphore") Fixes: 8db9e2a1b232 ("i40e: base driver") Fixes: 3b7271f3958a ("i40e/base: catch NVM write semaphore timeout and retry") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Luca Boccassi --- Cc: helin.zhang@intel.com Cc: Luca Boccassi Cc: David Marchand v2: * Fix more build error from same reason --- drivers/net/i40e/base/i40e_common.c | 4 +++- drivers/net/i40e/base/i40e_nvm.c | 8 +++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 8e3db0756c..e20bb9ac35 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -2,6 +2,8 @@ * Copyright(c) 2001-2020 Intel Corporation */ +#include + #include "i40e_type.h" #include "i40e_adminq.h" #include "i40e_prototype.h" @@ -4098,7 +4100,7 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, p->wr_csr_prot = (u64)number; p->wr_csr_prot |= (u64)logical_id << 32; i40e_debug(hw, I40E_DEBUG_INIT, - "HW Capability: wr_csr_prot = 0x%llX\n\n", + "HW Capability: wr_csr_prot = 0x%" PRIX64 "\n\n", (p->wr_csr_prot & 0xffff)); break; case I40E_AQ_CAP_ID_DIS_UNUSED_PORTS: diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c index 6466d86486..561ed21136 100644 --- a/drivers/net/i40e/base/i40e_nvm.c +++ b/drivers/net/i40e/base/i40e_nvm.c @@ -2,6 +2,8 @@ * Copyright(c) 2001-2020 Intel Corporation */ +#include + #include "i40e_prototype.h" /** @@ -77,7 +79,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw, if (ret_code) i40e_debug(hw, I40E_DEBUG_NVM, - "NVM acquire type %d failed time_left=%llu ret=%d aq_err=%d\n", + "NVM acquire type %d failed time_left=%" PRIu64 " ret=%d aq_err=%d\n", access, time_left, ret_code, hw->aq.asq_last_status); if (ret_code && time_left) { @@ -99,7 +101,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw, if (ret_code != I40E_SUCCESS) { hw->nvm.hw_semaphore_timeout = 0; i40e_debug(hw, I40E_DEBUG_NVM, - "NVM acquire timed out, wait %llu ms before trying again. status=%d aq_err=%d\n", + "NVM acquire timed out, wait %" PRIu64 " ms before trying again. status=%d aq_err=%d\n", time_left, ret_code, hw->aq.asq_last_status); } } @@ -1300,7 +1302,7 @@ STATIC enum i40e_status_code i40e_nvmupd_state_writing(struct i40e_hw *hw, gtime = rd32(hw, I40E_GLVFGEN_TIMER); if (gtime >= hw->nvm.hw_semaphore_timeout) { i40e_debug(hw, I40E_DEBUG_ALL, - "NVMUPD: write semaphore expired (%d >= %lld), retrying\n", + "NVMUPD: write semaphore expired (%d >= %" PRIu64 "), retrying\n", gtime, hw->nvm.hw_semaphore_timeout); i40e_release_nvm(hw); status = i40e_acquire_nvm(hw, I40E_RESOURCE_WRITE);