diff mbox series

test: fix bypassed out of place test

Message ID 20201105135857.1429328-1-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series test: fix bypassed out of place test |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Fan Zhang Nov. 5, 2020, 1:58 p.m. UTC 
  This patch fixes bypassed out of place test for PMDs that support
it.

Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API")
Cc: roy.fan.zhang@intel.com

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 app/test/test_cryptodev.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Dybkowski, AdamX Nov. 5, 2020, 2:01 p.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Fan Zhang
> Sent: Thursday, 5 November, 2020 14:59
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Subject: [dpdk-dev] test: fix bypassed out of place test
> 
> This patch fixes bypassed out of place test for PMDs that support it.
> 
> Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API")
> Cc: roy.fan.zhang@intel.com
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>

Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>

Thanks Fan for quick fixing action.
Akhil, please apply this for rc3.

Adam
Akhil Goyal Nov. 12, 2020, 9:08 p.m. UTC | #2 
> > This patch fixes bypassed out of place test for PMDs that support it.
> >
> > Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API")
> > Cc: roy.fan.zhang@intel.com
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> 
> Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> 
> Thanks Fan for quick fixing action.
> Akhil, please apply this for rc3.
> 
Applied to dpdk-next-crypto

Thanks.
Thomas Monjalon Nov. 15, 2020, 11:12 a.m. UTC | #3 
12/11/2020 22:08, Akhil Goyal:
> 
> > > This patch fixes bypassed out of place test for PMDs that support it.
> > >
> > > Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API")
> > > Cc: roy.fan.zhang@intel.com
> > >
> > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > 
> > Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > 
> > Thanks Fan for quick fixing action.
> > Akhil, please apply this for rc3.
> > 
> Applied to dpdk-next-crypto

Akhil, please don't merge a patch without a proper explanation.
It does not even explain what was the issue.
diff mbox series

Patch

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index d7d7ab5c6..8189053c1 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -6771,9 +6771,6 @@  test_mixed_auth_cipher(const struct mixed_cipher_auth_test_data *tdata,
 		return -ENOTSUP;
 	}
 
-	if (op_mode == OUT_OF_PLACE)
-		return -ENOTSUP;
-
 	/* Create the session */
 	if (verify)
 		retval = create_wireless_algo_cipher_auth_session(