diff mbox series

[dpdk-kmods] igb_uio: include MODULE_CFLAGS in Kbuild

Message ID 20201028181557.3662981-1-luca.boccassi@gmail.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series [dpdk-kmods] igb_uio: include MODULE_CFLAGS in Kbuild | expand

Checks

Context Check Description
ci/Intel-compilation fail apply issues
ci/checkpatch success coding style OK

Commit Message

Luca Boccassi Oct. 28, 2020, 6:15 p.m. UTC 
From: Luca Boccassi <luca.boccassi@microsoft.com>

Necessary to get build flags from DKMS.

See:

https://git.dpdk.org/dpdk/commit/?id=816d967717

Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
 linux/igb_uio/Kbuild | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon Oct. 29, 2020, 8:58 p.m. UTC | #1 
28/10/2020 19:15, luca.boccassi@gmail.com:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
> 
> Necessary to get build flags from DKMS.
> 
> See:
> 
> https://git.dpdk.org/dpdk/commit/?id=816d967717
[...]
> --- a/linux/igb_uio/Kbuild
> +++ b/linux/igb_uio/Kbuild
> @@ -1 +1,2 @@
> +ccflags-y := $(MODULE_CFLAGS)
>  obj-m := igb_uio.o

Yes this patch was not migrated because I though it was referring
to a DPDK-specific variable.
So you mean MODULE_CFLAGS is from the kernel build system?
Luca Boccassi Oct. 30, 2020, 4:33 p.m. UTC | #2 
On Thu, 29 Oct 2020, 20:58 Thomas Monjalon, <thomas@monjalon.net> wrote:

> 28/10/2020 19:15, luca.boccassi@gmail.com:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > Necessary to get build flags from DKMS.
> >
> > See:
> >
> > https://git.dpdk.org/dpdk/commit/?id=816d967717
> [...]
> > --- a/linux/igb_uio/Kbuild
> > +++ b/linux/igb_uio/Kbuild
> > @@ -1 +1,2 @@
> > +ccflags-y := $(MODULE_CFLAGS)
> >  obj-m := igb_uio.o
>
> Yes this patch was not migrated because I though it was referring
> to a DPDK-specific variable.
> So you mean MODULE_CFLAGS is from the kernel build system?
>

Yeah dkms uses it

>
diff mbox series

Patch

diff --git a/linux/igb_uio/Kbuild b/linux/igb_uio/Kbuild
index 98c98fe..3ab85c4 100644
--- a/linux/igb_uio/Kbuild
+++ b/linux/igb_uio/Kbuild
@@ -1 +1,2 @@ 
+ccflags-y := $(MODULE_CFLAGS)
 obj-m := igb_uio.o