| Message ID | 20201012130348.3212-4-conor.walsh@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | devtools: abi breakage checks | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
On 12/10/2020 14:03, Conor Walsh wrote: > Change dump file not found from an error to a warning to make check-abi.sh > compatible with the changes to test-meson-builds.sh needed to use > prebuilt references. > > Signed-off-by: Conor Walsh <conor.walsh@intel.com> > > --- > devtools/check-abi.sh | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh > index ab6748cfb..60d88777e 100755 > --- a/devtools/check-abi.sh > +++ b/devtools/check-abi.sh > @@ -46,8 +46,7 @@ for dump in $(find $refdir -name "*.dump"); do > fi > dump2=$(find $newdir -name $name) > if [ -z "$dump2" ] || [ ! -e "$dump2" ]; then > - echo "Error: can't find $name in $newdir" > - error=1 > + echo "WARNING: can't find $name in $newdir, are you building with all dependencies?" > continue > fi > abidiff $ABIDIFF_OPTIONS $dump $dump2 || { > Acked-by: Ray Kinsella <mdr@ashroe.eu>
diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh index ab6748cfb..60d88777e 100755 --- a/devtools/check-abi.sh +++ b/devtools/check-abi.sh @@ -46,8 +46,7 @@ for dump in $(find $refdir -name "*.dump"); do fi dump2=$(find $newdir -name $name) if [ -z "$dump2" ] || [ ! -e "$dump2" ]; then - echo "Error: can't find $name in $newdir" - error=1 + echo "WARNING: can't find $name in $newdir, are you building with all dependencies?" continue fi abidiff $ABIDIFF_OPTIONS $dump $dump2 || {
Change dump file not found from an error to a warning to make check-abi.sh compatible with the changes to test-meson-builds.sh needed to use prebuilt references. Signed-off-by: Conor Walsh <conor.walsh@intel.com> --- devtools/check-abi.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)