| Message ID | 20200928091712.7946-2-maxime.coquelin@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Maxime Coquelin |
| Headers | show |
| Series | vhost: remove dequeue zero-copy support | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
> -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: Monday, September 28, 2020 5:17 PM > To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Stokes, Ian > <ian.stokes@intel.com> > Cc: Maxime Coquelin <maxime.coquelin@redhat.com> > Subject: [PATCH v2 1/4] net/vhost: remove dequeue zero-copy support > > The dequeue zero-copy feature from the Vhost library is > being removed in this release, this patch remove its support > in the Vhost PMD. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > --- > drivers/net/vhost/rte_eth_vhost.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/net/vhost/rte_eth_vhost.c > b/drivers/net/vhost/rte_eth_vhost.c > index ce32be9ce3..5a39293083 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -29,7 +29,6 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM}; > #define ETH_VHOST_IFACE_ARG "iface" > #define ETH_VHOST_QUEUES_ARG "queues" > #define ETH_VHOST_CLIENT_ARG "client" > -#define ETH_VHOST_DEQUEUE_ZERO_COPY "dequeue-zero-copy" > #define ETH_VHOST_IOMMU_SUPPORT "iommu-support" > #define ETH_VHOST_POSTCOPY_SUPPORT "postcopy-support" > #define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso" > @@ -41,7 +40,6 @@ static const char *valid_arguments[] = { > ETH_VHOST_IFACE_ARG, > ETH_VHOST_QUEUES_ARG, > ETH_VHOST_CLIENT_ARG, > - ETH_VHOST_DEQUEUE_ZERO_COPY, > ETH_VHOST_IOMMU_SUPPORT, > ETH_VHOST_POSTCOPY_SUPPORT, > ETH_VHOST_VIRTIO_NET_F_HOST_TSO, > @@ -1501,7 +1499,6 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) > uint64_t flags = 0; > uint64_t disable_flags = 0; > int client_mode = 0; > - int dequeue_zero_copy = 0; > int iommu_support = 0; > int postcopy_support = 0; > int tso = 0; > @@ -1561,16 +1558,6 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) > flags |= RTE_VHOST_USER_CLIENT; > } > > - if (rte_kvargs_count(kvlist, ETH_VHOST_DEQUEUE_ZERO_COPY) == 1) { > - ret = rte_kvargs_process(kvlist, ETH_VHOST_DEQUEUE_ZERO_COPY, > - &open_int, &dequeue_zero_copy); > - if (ret < 0) > - goto out_free; > - > - if (dequeue_zero_copy) > - flags |= RTE_VHOST_USER_DEQUEUE_ZERO_COPY; > - } > - > if (rte_kvargs_count(kvlist, ETH_VHOST_IOMMU_SUPPORT) == 1) { > ret = rte_kvargs_process(kvlist, ETH_VHOST_IOMMU_SUPPORT, > &open_int, &iommu_support); > @@ -1674,7 +1661,6 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vhost, > "iface=<ifc> " > "queues=<int> " > "client=<0|1> " > - "dequeue-zero-copy=<0|1> " > "iommu-support=<0|1> " > "postcopy-support=<0|1> " > "tso=<0|1> " > -- > 2.26.2 Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index ce32be9ce3..5a39293083 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -29,7 +29,6 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM}; #define ETH_VHOST_IFACE_ARG "iface" #define ETH_VHOST_QUEUES_ARG "queues" #define ETH_VHOST_CLIENT_ARG "client" -#define ETH_VHOST_DEQUEUE_ZERO_COPY "dequeue-zero-copy" #define ETH_VHOST_IOMMU_SUPPORT "iommu-support" #define ETH_VHOST_POSTCOPY_SUPPORT "postcopy-support" #define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso" @@ -41,7 +40,6 @@ static const char *valid_arguments[] = { ETH_VHOST_IFACE_ARG, ETH_VHOST_QUEUES_ARG, ETH_VHOST_CLIENT_ARG, - ETH_VHOST_DEQUEUE_ZERO_COPY, ETH_VHOST_IOMMU_SUPPORT, ETH_VHOST_POSTCOPY_SUPPORT, ETH_VHOST_VIRTIO_NET_F_HOST_TSO, @@ -1501,7 +1499,6 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) uint64_t flags = 0; uint64_t disable_flags = 0; int client_mode = 0; - int dequeue_zero_copy = 0; int iommu_support = 0; int postcopy_support = 0; int tso = 0; @@ -1561,16 +1558,6 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) flags |= RTE_VHOST_USER_CLIENT; } - if (rte_kvargs_count(kvlist, ETH_VHOST_DEQUEUE_ZERO_COPY) == 1) { - ret = rte_kvargs_process(kvlist, ETH_VHOST_DEQUEUE_ZERO_COPY, - &open_int, &dequeue_zero_copy); - if (ret < 0) - goto out_free; - - if (dequeue_zero_copy) - flags |= RTE_VHOST_USER_DEQUEUE_ZERO_COPY; - } - if (rte_kvargs_count(kvlist, ETH_VHOST_IOMMU_SUPPORT) == 1) { ret = rte_kvargs_process(kvlist, ETH_VHOST_IOMMU_SUPPORT, &open_int, &iommu_support); @@ -1674,7 +1661,6 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vhost, "iface=<ifc> " "queues=<int> " "client=<0|1> " - "dequeue-zero-copy=<0|1> " "iommu-support=<0|1> " "postcopy-support=<0|1> " "tso=<0|1> "
The dequeue zero-copy feature from the Vhost library is being removed in this release, this patch remove its support in the Vhost PMD. Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> --- drivers/net/vhost/rte_eth_vhost.c | 14 -------------- 1 file changed, 14 deletions(-)