| Message ID | 20200915083836.18805-2-felix.moessbauer@siemens.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | David Marchand |
| Headers | show |
| Series | [1/2] Fix build of apps with external dependencies | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
15/09/2020 10:38, Felix Moessbauer: > This fix initializes the dependency object with the external > dependency list. Previously, the external dependencies were > just ignored. > > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> > --- > --- a/app/meson.build > +++ b/app/meson.build > if build > - dep_objs = [] > + dep_objs = ext_deps Bruce, do you confirm this is required?
On Tue, Oct 20, 2020 at 04:12:58PM +0200, Thomas Monjalon wrote: > 15/09/2020 10:38, Felix Moessbauer: > > This fix initializes the dependency object with the external > > dependency list. Previously, the external dependencies were > > just ignored. > > > > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> > > --- > > --- a/app/meson.build > > +++ b/app/meson.build > > if build > > - dep_objs = [] > > + dep_objs = ext_deps > > Bruce, do you confirm this is required? > Yes, it looks a correct fix, as indeed the ext_deps value is ignored in the file. Acked-by: Bruce Richardson <bruce.richardson@intel.com>
diff --git a/app/meson.build b/app/meson.build index eb74f215a..ab43a8403 100644 --- a/app/meson.build +++ b/app/meson.build @@ -43,7 +43,7 @@ foreach app:apps subdir(name) if build - dep_objs = [] + dep_objs = ext_deps foreach d:deps dep_objs += get_variable(get_option('default_library') + '_rte_' + d)
This fix initializes the dependency object with the external dependency list. Previously, the external dependencies were just ignored. Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com> --- app/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)