Message ID | 20200909155302.28656-8-lance.richardson@broadcom.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Ajit Khaparde |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA685A04B5; Wed, 9 Sep 2020 17:54:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79E451C133; Wed, 9 Sep 2020 17:53:31 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 497381C12D for <dev@dpdk.org>; Wed, 9 Sep 2020 17:53:29 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id c196so2661229pfc.0 for <dev@dpdk.org>; Wed, 09 Sep 2020 08:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Itv97QWp4ZpvXpe1R6x6gqTKMZX2hp4z6m6lmdqgv3A=; b=YEURXbNxXBpDgza9BPVvvUZsNdzv0MAGQyit8Qsqj4s3NHULH/LmDJEHy5fiPRYNgd abJJJcwaD5LlIC5EorAtj1DZIEyhhM23yn3bB6yvru32XFAo4P2+YW8WHETnu5AvEjEj 7AqClf+3OfEBEE+3jZbO8/fg/AeN5qQQsq6Bk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Itv97QWp4ZpvXpe1R6x6gqTKMZX2hp4z6m6lmdqgv3A=; b=CTiFhSIBw8Z42TEyKKGi63Ser+5rvD6xHKMqpeCk2eNsdsnLrEbB3lT89X7UlB9/TU pFWrWGngS6gyMIUamYtfB6aJspk/CG9XwTdEDY0972emO2MULE4Smfwt1K8Cdc/WCsZC knLeaVYM7JMpablrvRQPXTG64RKLswNPVAIxNJYGVDhVPPuU3ybgRfwAmqP6hAuKftSE SDz9YVL7GffDkJnb7a3rG4tBXF5d6uBImLe9IRWypbtDkfRA+znobLBBS7L1kwW1ik9o 3JjHPg4RgwFrkcAnXgwtCyD7cpk/+D2KZsN7Njn1YzR7P6YQlzbD+TOl0AnNOcb3R7ae /4fg== X-Gm-Message-State: AOAM533OfHTeTWaoBtxm5phs2NKehoy91DwFIFJNuKXiTFoprAShV71E UBnNvmgqd692WHrGtD3jW/+zLBVUHOoz0w== X-Google-Smtp-Source: ABdhPJyCBpSJPDE3APOabPVed4QKE456MLQcb8307qU+35UujGwfJWxGFAx3+T8nBmTsYxCHSiZOrQ== X-Received: by 2002:a63:1e4e:: with SMTP id p14mr1064843pgm.73.1599666808478; Wed, 09 Sep 2020 08:53:28 -0700 (PDT) Received: from localhost.localdomain ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id h15sm3188427pfo.23.2020.09.09.08.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 08:53:28 -0700 (PDT) From: Lance Richardson <lance.richardson@broadcom.com> To: Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur <somnath.kotur@broadcom.com> Cc: dev@dpdk.org, Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com> Date: Wed, 9 Sep 2020 11:53:00 -0400 Message-Id: <20200909155302.28656-8-lance.richardson@broadcom.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200909155302.28656-1-lance.richardson@broadcom.com> References: <20200909155302.28656-1-lance.richardson@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 07/12] net/bnxt: increase max burst size for vector mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
net/bnxt: vector PMD improvements
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Lance Richardson
Sept. 9, 2020, 3:53 p.m. UTC
Increase the maximum supported burst size for the bnxt vector mode PMD from 32 to 64. Reviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com> --- drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 9/9/2020 4:53 PM, Lance Richardson wrote: > Increase the maximum supported burst size for the bnxt vector > mode PMD from 32 to 64. What is the motivation here? Like does it improve the performance? If so in which conditions etc.. It would be nice to describe the why & impact. > > Reviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com> > Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com> > Signed-off-by: Lance Richardson <lance.richardson@broadcom.com> > --- > drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_common.h b/drivers/net/bnxt/bnxt_rxtx_vec_common.h > index 2f28759d06..fc2a12272b 100644 > --- a/drivers/net/bnxt/bnxt_rxtx_vec_common.h > +++ b/drivers/net/bnxt/bnxt_rxtx_vec_common.h > @@ -9,8 +9,8 @@ > #include "bnxt_rxq.h" > #include "bnxt_rxr.h" > > -#define RTE_BNXT_MAX_RX_BURST 32U > -#define RTE_BNXT_MAX_TX_BURST 32U > +#define RTE_BNXT_MAX_RX_BURST 64U > +#define RTE_BNXT_MAX_TX_BURST 64U > #define RTE_BNXT_DESCS_PER_LOOP 4U > > #define TX_BD_FLAGS_CMPL ((1 << TX_BD_LONG_FLAGS_BD_CNT_SFT) | \ >
On Fri, Sep 11, 2020 at 11:19 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > On 9/9/2020 4:53 PM, Lance Richardson wrote: > > Increase the maximum supported burst size for the bnxt vector > > mode PMD from 32 to 64. > > What is the motivation here? Like does it improve the performance? If so in > which conditions etc.. It would be nice to describe the why & impact. > How about this: net/bnxt: increase max burst size for vector mode Increase the maximum supported burst size for the bnxt vector mode PMD from 32 to 64. With larger burst sizes, per-burst overhead is amortized over more packets, improving overall performance. For small packets this has been measured to provide a 4-10% increase in single-core throughput with testpmd iofwd. Thanks, Lance
On 9/11/2020 4:38 PM, Lance Richardson wrote: > On Fri, Sep 11, 2020 at 11:19 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: >> >> On 9/9/2020 4:53 PM, Lance Richardson wrote: >>> Increase the maximum supported burst size for the bnxt vector >>> mode PMD from 32 to 64. >> >> What is the motivation here? Like does it improve the performance? If so in >> which conditions etc.. It would be nice to describe the why & impact. >> > > How about this: > > net/bnxt: increase max burst size for vector mode > > Increase the maximum supported burst size for the bnxt vector > mode PMD from 32 to 64. With larger burst sizes, per-burst > overhead is amortized over more packets, improving overall > performance. For small packets this has been measured to > provide a 4-10% increase in single-core throughput with > testpmd iofwd. > Will update while merging, thanks.
diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_common.h b/drivers/net/bnxt/bnxt_rxtx_vec_common.h index 2f28759d06..fc2a12272b 100644 --- a/drivers/net/bnxt/bnxt_rxtx_vec_common.h +++ b/drivers/net/bnxt/bnxt_rxtx_vec_common.h @@ -9,8 +9,8 @@ #include "bnxt_rxq.h" #include "bnxt_rxr.h" -#define RTE_BNXT_MAX_RX_BURST 32U -#define RTE_BNXT_MAX_TX_BURST 32U +#define RTE_BNXT_MAX_RX_BURST 64U +#define RTE_BNXT_MAX_TX_BURST 64U #define RTE_BNXT_DESCS_PER_LOOP 4U #define TX_BD_FLAGS_CMPL ((1 << TX_BD_LONG_FLAGS_BD_CNT_SFT) | \