From patchwork Fri Aug 7 12:57:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vipul Ashri X-Patchwork-Id: 75325 X-Patchwork-Delegate: chenbo.xia@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03A50A04B2; Sun, 9 Aug 2020 02:22:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D263F1C031; Sun, 9 Aug 2020 02:22:53 +0200 (CEST) Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by dpdk.org (Postfix) with ESMTP id 1E5991C044 for ; Fri, 7 Aug 2020 14:58:06 +0200 (CEST) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 077CgHfh124158 for ; Fri, 7 Aug 2020 12:58:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=szjgrZxQJ2dTIdvSYfXRTDsYNMmzEAbiDy02Ns2RNto=; b=DnQuiNyHdCkak4v0qBFonB/OdRe1LY3PAtXpMeoLagzcQHdOr4jlzY5FdgCoT/d4cXcr vvtQ/Q5/5U89jmIPDvx//RFucjQku7/btHej+3UYSyIwAsgS4VELAXDc1mOJPb6GnbJN b9rek6rWRptkCA1AYbh17LQMbMtaZwK4ROKhh07lrrDa9erpPDh+ANOaBvCSGVihLvIP 1tv10eahhjQ28hxpevrjCuUrHKrkJK0Hvd3b3IB+wlSvuViylvPpliMcOr3fg1eohVZ7 SRfElmglpuE/K7Z0N9Gqgnx/nylO8eQDGndaic1OMngDrDZRKlRPBHSR+zE04jsxzPu2 Dg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 32r6fxrccg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 07 Aug 2020 12:58:06 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 077ChEM4061662 for ; Fri, 7 Aug 2020 12:58:05 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 32qy8qjvqr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 07 Aug 2020 12:58:05 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 077Cw48p000820 for ; Fri, 7 Aug 2020 12:58:05 GMT Received: from VASHRI-IN.in.oracle.com (/10.166.173.174) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 07 Aug 2020 05:58:04 -0700 From: Vipul Ashri To: dev@dpdk.org Date: Fri, 7 Aug 2020 18:27:31 +0530 Message-Id: <20200807125731.1287-1-vipul.ashri@oracle.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9705 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008070091 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9705 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 impostorscore=0 adultscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=999 phishscore=0 lowpriorityscore=0 suspectscore=1 spamscore=0 clxscore=1011 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008070091 X-Mailman-Approved-At: Sun, 09 Aug 2020 02:22:53 +0200 Subject: [dpdk-dev] [PATCH] Virtio TX: reverting a small change causing Virtio standard TX broken X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Virtio Standard TX broken : Reverting a small change added few months back which has caused breakage in Virtio Standard TX path. During basic ping Tx/Rx testing of net_virtio pmd driver using standard Tx path, We saw TX is broken since anomaly code added by below patch once submitted http://git.dpdk.org/dpdk/patch/?id=57f90f89458807bccc63425e4b72796870177977 Reviewed-by: Chenbo Xia Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtqueue.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h index 105a9c00c..81118d9fb 100644 --- a/drivers/net/virtio/virtqueue.h +++ b/drivers/net/virtio/virtqueue.h @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq) /* avoid write operation when necessary, to lessen cache issues */ #define ASSIGN_UNLESS_EQUAL(var, val) do { \ - typeof(var) var_ = (var); \ - typeof(val) val_ = (val); \ - if ((var_) != (val_)) \ - (var_) = (val_); \ + if ((var) != (val)) \ + (var) = (val); \ } while (0) #define virtqueue_clear_net_hdr(hdr) do { \