diff mbox series

[04/14] net/bnxt: fix to avoid accumulation of flow counters

Message ID 20200717094935.9337-5-somnath.kotur@broadcom.com (mailing list archive)
State Superseded, archived
Delegated to: Ajit Khaparde
Headers
Series bnxt patches |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Somnath Kotur July 17, 2020, 9:49 a.m. UTC 
  OVS-DPDK is accumulating the flow counters that are returned as part
of the flow_query API and it is being issued atleast 3 times every second.
So there is no need to accumulate the counts internally in the driver.

Fixes: 306c2d28e247 ("net/bnxt: add support for flow query with action_type COUNT")

Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
 drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c
index 34a6ec3..febda94 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c
@@ -315,8 +315,8 @@  static int ulp_get_single_flow_stat(struct tf *tfp,
 	/* TBD - Get PKT/BYTE COUNT SHIFT/MASK from Template */
 	sw_cntr_indx = hw_cntr_id - fc_info->shadow_hw_tbl[dir].start_idx;
 	sw_acc_tbl_entry = &fc_info->sw_acc_tbl[dir][sw_cntr_indx];
-	sw_acc_tbl_entry->pkt_count += FLOW_CNTR_PKTS(stats, dparms);
-	sw_acc_tbl_entry->byte_count += FLOW_CNTR_BYTES(stats, dparms);
+	sw_acc_tbl_entry->pkt_count = FLOW_CNTR_PKTS(stats, dparms);
+	sw_acc_tbl_entry->byte_count = FLOW_CNTR_BYTES(stats, dparms);
 
 	return rc;
 }