From patchwork Thu Jul 16 19:07:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akhil Goyal X-Patchwork-Id: 74269 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63353A0540; Thu, 16 Jul 2020 21:07:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 014941BE95; Thu, 16 Jul 2020 21:07:30 +0200 (CEST) Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by dpdk.org (Postfix) with ESMTP id E64F92C4F for ; Thu, 16 Jul 2020 21:07:27 +0200 (CEST) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 738432006E6; Thu, 16 Jul 2020 21:07:27 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 68D392006E5; Thu, 16 Jul 2020 21:07:22 +0200 (CEST) Received: from lsv03273.swis.in-blr01.nxp.com (lsv03273.swis.in-blr01.nxp.com [92.120.147.113]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 5E39640294; Fri, 17 Jul 2020 03:07:16 +0800 (SGT) From: Akhil Goyal To: dev@dpdk.org Cc: declan.doherty@intel.com, asomalap@amd.com, anoobj@marvell.com, roy.fan.zhang@intel.com, fiona.trahe@intel.com, rnagadheeraj@marvell.com, adwivedi@marvell.com, jianjay.zhou@huawei.com, pablo.de.lara.guarch@intel.com, adamx.dybkowski@intel.com, Akhil Goyal Date: Fri, 17 Jul 2020 00:37:13 +0530 Message-Id: <20200716190713.23296-1-akhil.goyal@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200520152612.2920-1-akhil.goyal@nxp.com> References: <20200520152612.2920-1-akhil.goyal@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Subject: [dpdk-dev] [PATCH v2] test/crypto: skip unsupported cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" blockcipher cases are either returning TEST_SUCCESS or TEST_FAILED as status, but the test may not be supported by the PMD which is also a success case for the PMD. Hence checking for status == TEST_FAILED for setting the overall status as failed. Signed-off-by: Akhil Goyal Reviewed-by: Bruce Richardson Acked-by: Ankur Dwivedi --- app/test/test_cryptodev_blockcipher.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c index 642b54971..221262341 100644 --- a/app/test/test_cryptodev_blockcipher.c +++ b/app/test/test_cryptodev_blockcipher.c @@ -107,7 +107,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, "Test Skipped.\n"); snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "SKIPPED"); - return 0; + return TEST_SKIPPED; } } if (t->feature_mask & BLOCKCIPHER_TEST_FEATURE_SG) { @@ -120,7 +120,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, "Test Skipped.\n"); snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "SKIPPED"); - return 0; + return TEST_SKIPPED; } } else { if (!(feat_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) { @@ -129,7 +129,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, "Test Skipped.\n"); snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "SKIPPED"); - return 0; + return TEST_SKIPPED; } } @@ -146,7 +146,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, "Test Skipped.\n"); snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "SKIPPED"); - return 0; + return TEST_SKIPPED; } } @@ -163,7 +163,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, "Device does not support this algorithm." "Test Skipped.\n"); snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "SKIPPED"); - return 0; + return TEST_SKIPPED; } /* preparing data */ @@ -435,6 +435,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t, init_xform, sess_priv_mpool); if (status == -ENOTSUP) { snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "UNSUPPORTED"); + status = TEST_SKIPPED; goto error_exit; } if (!sess || status < 0) { @@ -780,9 +781,8 @@ test_blockcipher_all_tests(struct rte_mempool *mbuf_pool, printf(" %u) TestCase %s %s\n", test_index ++, tc->test_descr, test_msg); - if (status != TEST_SUCCESS) { - if (overall_status == TEST_SUCCESS) - overall_status = status; + if (status == TEST_FAILED) { + overall_status = status; if (tc->feature_mask & BLOCKCIPHER_TEST_FEATURE_STOPPER) break;