| Message ID | 20200709134823.9176-3-l.wojciechow@partner.samsung.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | introduce global debug flag | expand |
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | success | coding style OK |
On Thu, Jul 9, 2020 at 3:49 PM Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> wrote: > > Following flags were still present in the common_base config, > but they were not used anywhere in the code: > * CONFIG_RTE_LIBRTE_ACL_DEBUG > * CONFIG_RTE_LIBRTE_NFP_DEBUG_TX > * CONFIG_RTE_LIBRTE_NFP_DEBUG_RX > * CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG This could be separated from the rte_debug series. In the armv8 crypto driver case, it is a typo (Cc: Ruifeng for info). $ git show 169ca3db55 |grep CRYPTO_DEBUG +CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG=n +#ifdef RTE_LIBRTE_ARMV8_CRYPTO_DEBUG
> -----Original Message----- > From: David Marchand <david.marchand@redhat.com> > Sent: Thursday, July 16, 2020 3:43 PM > To: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> > Cc: thomas@monjalon.net; dev <dev@dpdk.org>; Ruifeng Wang > <Ruifeng.Wang@arm.com> > Subject: Re: [dpdk-dev] [PATCH v3 2/4] config: remove unused config flags > > On Thu, Jul 9, 2020 at 3:49 PM Lukasz Wojciechowski > <l.wojciechow@partner.samsung.com> wrote: > > > > Following flags were still present in the common_base config, but they > > were not used anywhere in the code: > > * CONFIG_RTE_LIBRTE_ACL_DEBUG > > * CONFIG_RTE_LIBRTE_NFP_DEBUG_TX > > * CONFIG_RTE_LIBRTE_NFP_DEBUG_RX > > * CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG > > This could be separated from the rte_debug series. > In the armv8 crypto driver case, it is a typo (Cc: Ruifeng for info). Yes, the armv8 crypto one is a typo. It should be CONFIG_RTE_LIBRTE_ARMV8_CRYPTO_DEBUG, without PMD. The configuration is expected to be used by armv8 crypto PMD. I will send a patch to fix this. Thanks. /Ruifeng > > $ git show 169ca3db55 |grep CRYPTO_DEBUG > +CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG=n > +#ifdef RTE_LIBRTE_ARMV8_CRYPTO_DEBUG > > > -- > David Marchand
diff --git a/config/common_base b/config/common_base index cc9d034be..897100887 100644 --- a/config/common_base +++ b/config/common_base @@ -388,8 +388,6 @@ CONFIG_RTE_IBVERBS_LINK_STATIC=n # Compile burst-oriented Netronome NFP PMD driver # CONFIG_RTE_LIBRTE_NFP_PMD=n -CONFIG_RTE_LIBRTE_NFP_DEBUG_TX=n -CONFIG_RTE_LIBRTE_NFP_DEBUG_RX=n # QLogic 10G/25G/40G/50G/100G PMD # @@ -599,7 +597,6 @@ CONFIG_RTE_CRYPTO_MAX_DEVS=64 # Compile PMD for ARMv8 Crypto device # CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO=n -CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG=n # # Compile NXP CAAM JR crypto Driver @@ -967,7 +964,6 @@ CONFIG_RTE_LIBRTE_LPM_DEBUG=n # Compile librte_acl # CONFIG_RTE_LIBRTE_ACL=y -CONFIG_RTE_LIBRTE_ACL_DEBUG=n # # Compile librte_power
Following flags were still present in the common_base config, but they were not used anywhere in the code: * CONFIG_RTE_LIBRTE_ACL_DEBUG * CONFIG_RTE_LIBRTE_NFP_DEBUG_TX * CONFIG_RTE_LIBRTE_NFP_DEBUG_RX * CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> --- config/common_base | 4 ---- 1 file changed, 4 deletions(-)