From patchwork Thu Jul 9 08:00:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinan Sun X-Patchwork-Id: 73609 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B3DFA0526; Thu, 9 Jul 2020 10:16:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D1B71DE6D; Thu, 9 Jul 2020 10:14:30 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C74D61DE91 for ; Thu, 9 Jul 2020 10:14:17 +0200 (CEST) IronPort-SDR: JhJFHm8qwBFhS4VCRWfvuVguXyfF4MIM2LeGT8dlgjkQ6xP17pkuo8UAxPk5uv5uMNsfC+46Fi m3XyNnmG2cGA== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="212869378" X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="212869378" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2020 01:14:17 -0700 IronPort-SDR: 9qQy0d6TAs4FnHtef/OT/kAE4rIlRrTNVc8BbZHIBofteg/B3yD7IhwyAcFHu6N6oy1FgzcxU/ 20iICHCVW57A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="297989248" Received: from intel.sh.intel.com ([10.239.255.18]) by orsmga002.jf.intel.com with ESMTP; 09 Jul 2020 01:14:14 -0700 From: Guinan Sun To: dev@dpdk.org Cc: Jeff Guo , Zhao1 Wei , Guinan Sun , Zalfresso-Jundzillo Date: Thu, 9 Jul 2020 08:00:39 +0000 Message-Id: <20200709080046.65879-13-guinanx.sun@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200709080046.65879-1-guinanx.sun@intel.com> References: <20200702031329.4495-1-guinanx.sun@intel.com> <20200709080046.65879-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH v3 12/19] net/ixgbe/base: remove unnecessary log message FC autonego X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The function ixgbe_device_supports_autoneg_fc is checking whether a particular device and medium configuration is supporting Flow Control Autonegotiation. In case of non-support, the message is always logged which is confusing. The fix is removing unnecessary log entry. Signed-off-by: Zalfresso-Jundzillo Signed-off-by: Guinan Sun Reviewed-by: Wei Zhao --- drivers/net/ixgbe/base/ixgbe_common.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index 4e5d909ca..927877b6a 100644 --- a/drivers/net/ixgbe/base/ixgbe_common.c +++ b/drivers/net/ixgbe/base/ixgbe_common.c @@ -186,10 +186,6 @@ bool ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw) break; } - if (!supported) - ERROR_REPORT2(IXGBE_ERROR_UNSUPPORTED, - "Device %x does not support flow control autoneg", - hw->device_id); return supported; }