From patchwork Thu Jul 9 07:34:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parav Pandit X-Patchwork-Id: 73585 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7B1FA0526; Thu, 9 Jul 2020 09:35:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E75871DCAE; Thu, 9 Jul 2020 09:35:47 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150077.outbound.protection.outlook.com [40.107.15.77]) by dpdk.org (Postfix) with ESMTP id AD4621DCAD for ; Thu, 9 Jul 2020 09:35:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GNMqQtH+9VDchmXGNMT8C2FLiTrK1VxafppP1oSWnEFYcw4Q2tfcoPLNJdYyYadIu38Z3q0akZDWPhwAVfQ8SiP1BKStzez6X0XGxgZ3tDTXrxLiSZPGBarHGnf5J1VRdsBdL//l5YtveGJLQcLDw2jTkD+nX0iShwAXOGycyMyW8MFwBnz+2n3R8KlSzEO+4w8dCjKC1MPhDzF4yWkICmBkmRIPVpB75OsrL98VXL+5WBQ+X3G0wPnYgK0/OKZVn1AH9PvjfY5pR+qiIVaKAFlAJUkJzi3HZpchleLy59cN4fSioXGWU0oGLxLrWWdgscmicWascJG6Qn4MKyqJ3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RpWOBd3pblhqrkJ0OEo5WAC0kGA/NL4QMCyIMNN5gO8=; b=TzvMywWWjWy5MD0kXCsLRgXNWpAjVhkBhix3Nl5oc034CtEPsne9fVesezyeAsYZxOcvQtvSgdy5P5gJHAPIwDiQlXihodx/foWiL8UUo2HrQV06+dujW64BNhCPnjQzzta8elGRliQ1MSukbFoNWpmie5fl0lTV5TDfZK3mW1PqyGdOTxcHVlZcrmLFjsQ4yCelSsZhE+rXcIxmb+2Ep2EI4C39Dqd3SNWjGrtUhDMrQtClVuKnk3e/wOzmrMW2X0Jaw3fKjN8rkH/sXJuykaykFo0psYxKrzcnx9SieHW901llpjxyDLWymplVKKSrS5eERqgxvgjv7n9sG1judA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RpWOBd3pblhqrkJ0OEo5WAC0kGA/NL4QMCyIMNN5gO8=; b=ATBWcbT2KAe/uuCmGdeP31s3hRO1UDe0LP5KYxzViQFwc+31jO2dHuHIbstP9fb9PDnHiNe1A4cVqNhYMLzQUQHECMICv8zpfhvevNuNfP6x25OoeBD81Nsvzb0dPZLeQOHf4kuJ/ty+XlymH7b2qXlsirp1+wgSZKDpOL2cklw= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from DB7PR05MB4876.eurprd05.prod.outlook.com (2603:10a6:10:1d::32) by DB7PR05MB5084.eurprd05.prod.outlook.com (2603:10a6:10:15::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.28; Thu, 9 Jul 2020 07:35:44 +0000 Received: from DB7PR05MB4876.eurprd05.prod.outlook.com ([fe80::8cb3:93cb:c3ef:4293]) by DB7PR05MB4876.eurprd05.prod.outlook.com ([fe80::8cb3:93cb:c3ef:4293%5]) with mapi id 15.20.3174.022; Thu, 9 Jul 2020 07:35:44 +0000 From: Parav Pandit To: dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net Cc: rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com, joyce.kong@arm.com, Parav Pandit Date: Thu, 9 Jul 2020 10:34:46 +0300 Message-Id: <20200709073452.948894-4-parav@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200709073452.948894-1-parav@mellanox.com> References: <20200610171728.89-2-parav@mellanox.com> <20200709073452.948894-1-parav@mellanox.com> X-ClientProxiedBy: SN4PR0501CA0104.namprd05.prod.outlook.com (2603:10b6:803:42::21) To DB7PR05MB4876.eurprd05.prod.outlook.com (2603:10a6:10:1d::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by SN4PR0501CA0104.namprd05.prod.outlook.com (2603:10b6:803:42::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.9 via Frontend Transport; Thu, 9 Jul 2020 07:35:42 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [208.176.44.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: eb6c0c38-6173-4eb5-5b9b-08d823dab030 X-MS-TrafficTypeDiagnostic: DB7PR05MB5084: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:327; X-Forefront-PRVS: 04599F3534 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wyQ/oe5O73tJCdtiA4tC0b05kUDD4cPoWSpCygKIsKIZka2maC2l1unrtq6tsMj4HlTJ0YalsqGAaGvXtsNATIc8kFe6a9khJBWXjreexmvsSRM/Y02KhXyvaGbefwdUmMoji+/lH+C2J8Htj4biR2uYPU3qJfOlBdLDUf5H0qW8M2OxXv+s98P/4lRLAJACIuDD4VPpXOKr7buCw4gKduSCsXV2nWChkcDZpmOXymmUTyRAMn12Bux6Ew73l/bgriF0fnY8TYxWJ/LfoT7PY7VbRb0IxJnvIYnsMh2/+FU/KuB03h/eelzIuyd7ckHK X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR05MB4876.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(136003)(39860400002)(346002)(376002)(2906002)(16526019)(186003)(26005)(6506007)(6512007)(52116002)(107886003)(5660300002)(1076003)(4326008)(316002)(83380400001)(36756003)(478600001)(86362001)(6486002)(66556008)(66476007)(956004)(2616005)(8936002)(8676002)(66946007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Xw7WyFUAz8k7a5uEAhiO0axWnjCGwxVip2I100rtvs0AjvNgpiq7bGmkOF1svP+g97+t3JnRvjFgOP7NHxr2onKI3JTkzmvCHzhStNR3TPUWCTYfgss0rmGsHug0xc8KL3Ycc6xd7vw+3Y3+pgkdRVVyzKNW8ScVfs1Q9ZIVw9yypekzqMM3GG/C10pJlb0V66MHLOXisRW/+Hqm63zkpHKo3oCvKDcADYstbZGhK8Be/6L+IJD92ZXvnZ2XxpzzqHrox4BFIDyXTC7GlmxadgG0QJWc9iZvqi/YawFaLR331QfRGcM/CyjZySooteXby5sTucFBB89QLaz1xzRaKwr2Zb7idqGtMXpbJ919K2zb/Uti3kCc0YDqheX4aUrlhjInXfAvLL+7cpAEnKEw8oP1fnUd/WEjsetCw19aaM/FYCFMD66XO0UOknVkx4BhBduY8wL7IWbhNN6smvSulcsEsCicde/uYZTEuD7hWH3DSYgP3v34vV7v+7a1tr+q X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb6c0c38-6173-4eb5-5b9b-08d823dab030 X-MS-Exchange-CrossTenant-AuthSource: DB7PR05MB4876.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2020 07:35:44.5872 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sP6hftWaVUV6u8BIyx3Tk/NIznw9rwypveo9uvJT6tQdhA698dzsn7jQBA72kB5D7e2Gac94Fby3DlacqtZjdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5084 Subject: [dpdk-dev] [PATCH v5 3/9] common/mlx5: fix empty input style in glue wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following two errors are reported when compiled with gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5). drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v2->v3: - new patch --- drivers/common/mlx5/linux/mlx5_glue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_glue.h b/drivers/common/mlx5/linux/mlx5_glue.h index 069d8540c..e5e052a6a 100644 --- a/drivers/common/mlx5/linux/mlx5_glue.h +++ b/drivers/common/mlx5/linux/mlx5_glue.h @@ -185,11 +185,11 @@ struct mlx5_glue { void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl); void *(*dr_create_flow_action_dest_port)(void *domain, uint32_t port); - void *(*dr_create_flow_action_drop)(); + void *(*dr_create_flow_action_drop)(void); void *(*dr_create_flow_action_push_vlan) (struct mlx5dv_dr_domain *domain, rte_be32_t vlan_tag); - void *(*dr_create_flow_action_pop_vlan)(); + void *(*dr_create_flow_action_pop_vlan)(void); void *(*dr_create_flow_tbl)(void *domain, uint32_t level); int (*dr_destroy_flow_tbl)(void *tbl); void *(*dr_create_domain)(struct ibv_context *ctx,