diff mbox series

net/ixgbe: enable 10Mb/s speed for x553

Message ID 20200628061255.68963-1-wei.zhao1@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series net/ixgbe: enable 10Mb/s speed for x553 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Zhao1, Wei June 28, 2020, 6:12 a.m. UTC 
  For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M
link speed, so enable it for the kind of ixgbe nic.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Guo, Jia June 29, 2020, 8:21 a.m. UTC | #1 
hi, wei

On 6/28/2020 2:12 PM, Wei Zhao wrote:
> For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M
> link speed, so enable it for the kind of ixgbe nic.


This is not an enabling patch i think, it just add the support link 
speed info for specific nic, so suggest you refine the commit log and 
bring my

ack at coming version.


> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>   drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index f8a84c565..d812579fe 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -4320,6 +4320,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
>   			link.link_speed = ETH_SPEED_NUM_100M;
>   		break;
>   
> +	case IXGBE_LINK_SPEED_10_FULL:
> +		link.link_speed = ETH_SPEED_NUM_10M;
> +		break;
> +
>   	case IXGBE_LINK_SPEED_100_FULL:
>   		link.link_speed = ETH_SPEED_NUM_100M;
>   		break;
Acked-by:  Jeff Guo <jia.guo@intel.com>
Zhao1, Wei June 30, 2020, 1:32 a.m. UTC | #2 
Hi, jia

> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Monday, June 29, 2020 4:21 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Subject: Re: [PATCH] net/ixgbe: enable 10Mb/s speed for x553
> 
> hi, wei
> 
> On 6/28/2020 2:12 PM, Wei Zhao wrote:
> > For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M link speed,
> > so enable it for the kind of ixgbe nic.
> 
> 
> This is not an enabling patch i think, it just add the support link speed info for
> specific nic, so suggest you refine the commit log and bring my
> 
> ack at coming version.
> 

Ok 

> 
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> >   drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index f8a84c565..d812579fe 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -4320,6 +4320,10 @@ ixgbe_dev_link_update_share(struct
> rte_eth_dev *dev,
> >   			link.link_speed = ETH_SPEED_NUM_100M;
> >   		break;
> >
> > +	case IXGBE_LINK_SPEED_10_FULL:
> > +		link.link_speed = ETH_SPEED_NUM_10M;
> > +		break;
> > +
> >   	case IXGBE_LINK_SPEED_100_FULL:
> >   		link.link_speed = ETH_SPEED_NUM_100M;
> >   		break;
> Acked-by:  Jeff Guo <jia.guo@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index f8a84c565..d812579fe 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4320,6 +4320,10 @@  ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
 			link.link_speed = ETH_SPEED_NUM_100M;
 		break;
 
+	case IXGBE_LINK_SPEED_10_FULL:
+		link.link_speed = ETH_SPEED_NUM_10M;
+		break;
+
 	case IXGBE_LINK_SPEED_100_FULL:
 		link.link_speed = ETH_SPEED_NUM_100M;
 		break;