diff mbox series

[v2,12/42] net/e1000/base: modify klocwork errors

Message ID	20200624075337.6768-13-guinanx.sun@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	Qi Zhang
Headers	IronPort-SDR: uZBtGdWjsHH+h7P8JgImipXgWj8jnrJ+m+1lKxvdQD78BHCrPSU23rx6w3BRDzSUrHsaAvjKjs qoJ0qvLGkYJQ== IronPort-SDR: SZ12ml9iWfDnLtxe5muR4cRPOib19OiIzmtqC56/MofzUZn5CsAJ7/gdRRzq5Lt4mX3PLVJMdM kYcs7Eprk0sQ== From: Guinan Sun <guinanx.sun@intel.com> To: dev@dpdk.org Cc: Jeff Guo <jia.guo@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Guinan Sun <guinanx.sun@intel.com>, Robert Konklewski <robertx.konklewski@intel.com>, Doug Dziggel <douglas.a.dziggel@intel.com> Date: Wed, 24 Jun 2020 07:53:07 +0000 Message-Id: <20200624075337.6768-13-guinanx.sun@intel.com> In-Reply-To: <20200624075337.6768-1-guinanx.sun@intel.com> References: <20200622064634.70941-1-guinanx.sun@intel.com> <20200624075337.6768-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH v2 12/42] net/e1000/base: modify klocwork errors Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	update e1000 base code \| [v2,00/42] update e1000 base code [v2,01/42] net/e1000/base: resolve flash presence for i210 devices [v2,02/42] net/e1000/base: i210 slow system clock update [v2,03/42] net/e1000/base: add ICL device id's [v2,04/42] net/e1000/base: remove shadowing variable declarations [v2,05/42] net/e1000/base: introduce flags [v2,06/42] net/e1000/base: modify MAC initialization for i211 [v2,07/42] net/e1000/base: modify parens to match other MAC checks [v2,08/42] net/e1000/base: expose xmdio methods [v2,09/42] net/e1000/base: fall through explicitly [v2,10/42] net/e1000/base: add function parameter descriptions [v2,11/42] net/e1000/base: modify fall through code comments [v2,12/42] net/e1000/base: modify klocwork errors [v2,13/42] net/e1000/base: modify klockwork about unused return values [v2,14/42] net/e1000/base: improve coding style [v2,15/42] net/e1000/base: modify HW level time sync mechanisms [v2,16/42] net/e1000/base: modify description [v2,17/42] net/e1000/base: remove duplicated codes from 82575 [v2,18/42] net/e1000/base: add definitions for ETQF register bit [v2,19/42] net/e1000/base: cleanup duplicate declaration [v2,20/42] net/e1000/base: expose MAC functions [v2,21/42] net/e1000/base: move definitions from 82575 to defines file [v2,22/42] net/e1000/base: add define to PCIm function state [v2,23/42] net/e1000/base: add missing register defines [v2,24/42] net/e1000/base: move the device reset definition [v2,25/42] net/e1000/base: increased timeout for ME ULP exit [v2,26/42] net/e1000/base: add missing device ID [v2,27/42] net/e1000/base: expose more future extended NVM [v2,28/42] net/e1000/base: add definition of EEE 2.5G setup register [v2,29/42] net/e1000/base: remove definitions [v2,30/42] net/e1000/base: remove useless statement [v2,31/42] net/e1000/base: add missed define for VFTA [v2,32/42] net/e1000/base: modify flow control setup [v2,33/42] net/e1000/base: led blinking fix for i210 [v2,34/42] net/e1000/base: expose new FEXTNVM registers and masks [v2,35/42] net/e1000/base: cleanup duplicate defines [v2,36/42] net/e1000/base: add support for Nahum10 [v2,37/42] net/e1000/base: add fall-through comments for switch cases [v2,38/42] net/e1000/base: modify typo in Alder Lake brand name [v2,39/42] net/e1000/base: introduce DPGFR register [v2,40/42] net/e1000/base: remove conditional compilation wrapper [v2,41/42] net/e1000/base: modify copyright [v2,42/42] net/e1000/base: update version

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

Guinan Sun June 24, 2020, 7:53 a.m. UTC

  This patch fixes klocwork scans errors relating to operands in bitwise
operations having different sizes.

Signed-off-by: Robert Konklewski <robertx.konklewski@intel.com>
Signed-off-by: Doug Dziggel <douglas.a.dziggel@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/e1000/base/e1000_82575.c | 2 +-
 drivers/net/e1000/base/e1000_i210.c  | 2 +-
 drivers/net/e1000/base/e1000_phy.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/e1000/base/e1000_82575.c b/drivers/net/e1000/base/e1000_82575.c
index f4856af9c..021a54fc5 100644
--- a/drivers/net/e1000/base/e1000_82575.c
+++ b/drivers/net/e1000/base/e1000_82575.c
@@ -1084,7 +1084,7 @@  STATIC void e1000_release_swfw_sync_82575(struct e1000_hw *hw, u16 mask)
 		; /* Empty */
 
 	swfw_sync = E1000_READ_REG(hw, E1000_SW_FW_SYNC);
-	swfw_sync &= ~mask;
+	swfw_sync &= (u32)~mask;
 	E1000_WRITE_REG(hw, E1000_SW_FW_SYNC, swfw_sync);
 
 	e1000_put_hw_semaphore_generic(hw);
diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c
index 5c2fe8a3e..b13730d84 100644
--- a/drivers/net/e1000/base/e1000_i210.c
+++ b/drivers/net/e1000/base/e1000_i210.c
@@ -117,7 +117,7 @@  void e1000_release_swfw_sync_i210(struct e1000_hw *hw, u16 mask)
 		; /* Empty */
 
 	swfw_sync = E1000_READ_REG(hw, E1000_SW_FW_SYNC);
-	swfw_sync &= ~mask;
+	swfw_sync &= (u32)~mask;
 	E1000_WRITE_REG(hw, E1000_SW_FW_SYNC, swfw_sync);
 
 	e1000_put_hw_semaphore_generic(hw);
diff --git a/drivers/net/e1000/base/e1000_phy.c b/drivers/net/e1000/base/e1000_phy.c
index c506d2344..6589c2c7f 100644
--- a/drivers/net/e1000/base/e1000_phy.c
+++ b/drivers/net/e1000/base/e1000_phy.c
@@ -597,7 +597,7 @@  s32 e1000_write_sfp_data_byte(struct e1000_hw *hw, u16 offset, u8 data)
 				 * lane and update whole word
 				 */
 				data_local = i2ccmd & 0xFF00;
-				data_local |= data;
+				data_local |= (u32)data;
 				i2ccmd = ((offset <<
 					E1000_I2CCMD_REG_ADDR_SHIFT) |
 					E1000_I2CCMD_OPCODE_WRITE | data_local);