From patchwork Wed Jun 24 07:53:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinan Sun X-Patchwork-Id: 72066 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEFF7A0350; Wed, 24 Jun 2020 10:04:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74B591D923; Wed, 24 Jun 2020 10:01:51 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 716E61D91B for ; Wed, 24 Jun 2020 10:01:48 +0200 (CEST) IronPort-SDR: nM2DTS+hRrJUngha/njNdK5ibisGqs32ZIlfbs0dAzCjBh3Fhqw7MwwGpnpoMLFb3nLohTpTsQ JLFh3hzVkbvQ== X-IronPort-AV: E=McAfee;i="6000,8403,9661"; a="132794544" X-IronPort-AV: E=Sophos;i="5.75,274,1589266800"; d="scan'208";a="132794544" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2020 01:01:44 -0700 IronPort-SDR: paRYdPiDACjseGi21aeEAbpaJOeGhL4w/C1sE0ePiQRhOw4p3PTZcolRecTSEqz9GSim3htkuB YDrrTRCLFmRw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,274,1589266800"; d="scan'208";a="385102677" Received: from intel.sh.intel.com ([10.239.255.48]) by fmsmga001.fm.intel.com with ESMTP; 24 Jun 2020 01:01:42 -0700 From: Guinan Sun To: dev@dpdk.org Cc: Jeff Guo , Wenzhuo Lu , Guinan Sun , Jeff Kirsher Date: Wed, 24 Jun 2020 07:53:06 +0000 Message-Id: <20200624075337.6768-12-guinanx.sun@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200624075337.6768-1-guinanx.sun@intel.com> References: <20200622064634.70941-1-guinanx.sun@intel.com> <20200624075337.6768-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH v2 11/42] net/e1000/base: modify fall through code comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Found some inconsistent code comments when it came to when we "fall through", so made them more consistent and non-repetitive. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/e1000/base/e1000_82575.c b/drivers/net/e1000/base/e1000_82575.c index bf193eb9e..f4856af9c 100644 --- a/drivers/net/e1000/base/e1000_82575.c +++ b/drivers/net/e1000/base/e1000_82575.c @@ -1560,14 +1560,21 @@ STATIC s32 e1000_setup_copper_link_82575(struct e1000_hw *hw) } switch (hw->phy.type) { case e1000_phy_i210: + /* fall through */ case e1000_phy_m88: switch (hw->phy.id) { case I347AT4_E_PHY_ID: + /* fall through */ case M88E1112_E_PHY_ID: + /* fall through */ case M88E1340M_E_PHY_ID: + /* fall through */ case M88E1543_E_PHY_ID: + /* fall through */ case M88E1512_E_PHY_ID: + /* fall through */ case I210_I_PHY_ID: + /* fall through */ ret_val = e1000_copper_link_setup_m88_gen2(hw); break; default: