diff mbox series

[v5,5/8] drivers: ignore pmdinfogen generation for Windows

Message ID	20200609103139.22168-6-talshn@mellanox.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: talshn@mellanox.com To: dev@dpdk.org Cc: thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com, Tal Shnaiderman <talshn@mellanox.com> Date: Tue, 9 Jun 2020 13:31:36 +0300 Message-Id: <20200609103139.22168-6-talshn@mellanox.com> In-Reply-To: <20200609103139.22168-1-talshn@mellanox.com> References: <20200609103139.22168-1-talshn@mellanox.com> Subject: [dpdk-dev] [PATCH v5 5/8] drivers: ignore pmdinfogen generation for Windows Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	Windows bus/pci support \| [v5,0/8] Windows bus/pci support [v5,1/8] eal: move OS common functions to single file [v5,2/8] pci: use OS generic memory mapping functions [v5,3/8] pci: build on Windows [v5,4/8] pci: fix format warning on Windows [v5,5/8] drivers: ignore pmdinfogen generation for Windows [v5,6/8] drivers: fix incorrect meson import folder for Windows [v5,7/8] bus/pci: introduce Windows support with stubs [v5,8/8] bus/pci: support Windows with bifurcated drivers

Checks

Context	Check	Description
ci/Intel-compilation	fail	apply issues
ci/checkpatch	success	coding style OK

Commit Message

Tal Shnaiderman June 9, 2020, 10:31 a.m. UTC

  From: Tal Shnaiderman <talshn@mellanox.com>

pmdinfogen generation is currently unsupported for Windows.
The relevant part in meson.build is skipped.

Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
---
 drivers/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Dmitry Kozlyuk June 17, 2020, 8:39 p.m. UTC | #1

On Tue,  9 Jun 2020 13:31:36 +0300
talshn@mellanox.com wrote:

> From: Tal Shnaiderman <talshn@mellanox.com>
> 
> pmdinfogen generation is currently unsupported for Windows.
> The relevant part in meson.build is skipped.
> 
> Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
> ---
>  drivers/meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/meson.build b/drivers/meson.build
> index cfb6a833c9..a7eac86790 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -107,6 +107,7 @@ foreach class:dpdk_driver_classes
>  
>  			dpdk_extra_ldflags += pkgconfig_extra_libs
>  
> +			if host_machine.system() != 'windows'
>  			# generate pmdinfo sources by building a temporary
>  			# lib and then running pmdinfogen on the contents of
>  			# that lib. The final lib reuses the object files and
> @@ -123,7 +124,7 @@ foreach class:dpdk_driver_classes
>  						'@OUTPUT@', pmdinfogen],
>  					output: out_filename,
>  					depends: [pmdinfogen, tmp_lib])
> -
> +			endif
>  			version_map = '@0@/@1@/@2@_version.map'.format(
>  					meson.current_source_dir(),
>  					drv_path, lib_name)

Lack of indentation here is misleading. If you move the comment above "if",
there's not much to rewrap inside after indenting.

diff mbox series

Patch

diff --git a/drivers/meson.build b/drivers/meson.build
index cfb6a833c9..a7eac86790 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -107,6 +107,7 @@  foreach class:dpdk_driver_classes
 
 			dpdk_extra_ldflags += pkgconfig_extra_libs
 
+			if host_machine.system() != 'windows'
 			# generate pmdinfo sources by building a temporary
 			# lib and then running pmdinfogen on the contents of
 			# that lib. The final lib reuses the object files and
@@ -123,7 +124,7 @@  foreach class:dpdk_driver_classes
 						'@OUTPUT@', pmdinfogen],
 					output: out_filename,
 					depends: [pmdinfogen, tmp_lib])
-
+			endif
 			version_map = '@0@/@1@/@2@_version.map'.format(
 					meson.current_source_dir(),
 					drv_path, lib_name)