From patchwork Wed May 20 10:22:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 70470 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4C11A0093; Wed, 20 May 2020 12:22:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB0121C2B2; Wed, 20 May 2020 12:22:29 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 742F21C21E for ; Wed, 20 May 2020 12:22:27 +0200 (CEST) IronPort-SDR: sEPrgNlIvOMOHIC7wAyR3XWkdz/6XICspbqMc9+WIX2R/cWOuzrtKwKl3ud6FmYXscKTaauOP6 rLb9ts2Xw6Lw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 03:22:26 -0700 IronPort-SDR: m+KgXOsL39IpzAmnnaJvFuJt1umcj4pWsGjaakdhLcJU/6Xm1G6LAZXIytE/d1k8Wc4syCaTNB 7L5upzZ93LYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,413,1583222400"; d="scan'208";a="308680150" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by FMSMGA003.fm.intel.com with ESMTP; 20 May 2020 03:22:24 -0700 From: Ferruh Yigit To: Hemant Agrawal , Sachin Saxena Cc: dev@dpdk.org, Ferruh Yigit , Thomas Monjalon , David Marchand , Xueming Zhang Date: Wed, 20 May 2020 11:22:22 +0100 Message-Id: <20200520102222.2241689-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] bus/fslmc: drop inline from non-static functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is no point in having non-static (and non-extern) inline functions. Also this breaks the build for the ICC [1] because of the 'internal' symbol check. When function is 'inline' ICC is ignoring 'section' attribute and not putting function to 'internal' section which breaks 'check-symbols.sh' script with below error. [1] qbman_swp_dqrr_next is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_dqrr_next qbman_swp_enqueue_multiple is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_enqueue_multiple qbman_swp_enqueue_multiple_desc is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_enqueue_multiple_desc qbman_swp_enqueue_multiple_fd is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_enqueue_multiple_fd qbman_swp_pull is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_pull qbman_swp_release is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_release Signed-off-by: Ferruh Yigit Acked-by: Hemant Agrawal Acked-by: Hemant Agrawal --- Cc: Xueming Zhang Cc: David Marchand I don't see the point of the 'inline' keyword in this key, but if it is explicitly required/requested we can look for another ways to fix icc build. --- drivers/bus/fslmc/qbman/qbman_portal.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c index d4223bdc8b..d7ff74c7a2 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.c +++ b/drivers/bus/fslmc/qbman/qbman_portal.c @@ -1019,7 +1019,7 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, return num_enqueued; } -inline int qbman_swp_enqueue_multiple(struct qbman_swp *s, +int qbman_swp_enqueue_multiple(struct qbman_swp *s, const struct qbman_eq_desc *d, const struct qbman_fd *fd, uint32_t *flags, @@ -1227,7 +1227,7 @@ static int qbman_swp_enqueue_multiple_fd_mem_back(struct qbman_swp *s, return num_enqueued; } -inline int qbman_swp_enqueue_multiple_fd(struct qbman_swp *s, +int qbman_swp_enqueue_multiple_fd(struct qbman_swp *s, const struct qbman_eq_desc *d, struct qbman_fd **fd, uint32_t *flags, @@ -1421,7 +1421,7 @@ static int qbman_swp_enqueue_multiple_desc_mem_back(struct qbman_swp *s, return num_enqueued; } -inline int qbman_swp_enqueue_multiple_desc(struct qbman_swp *s, +int qbman_swp_enqueue_multiple_desc(struct qbman_swp *s, const struct qbman_eq_desc *d, const struct qbman_fd *fd, int num_frames) @@ -1599,7 +1599,7 @@ static int qbman_swp_pull_mem_back(struct qbman_swp *s, return 0; } -inline int qbman_swp_pull(struct qbman_swp *s, struct qbman_pull_desc *d) +int qbman_swp_pull(struct qbman_swp *s, struct qbman_pull_desc *d) { return qbman_swp_pull_ptr(s, d); } @@ -1636,7 +1636,7 @@ void qbman_swp_prefetch_dqrr_next(struct qbman_swp *s) * only once, so repeated calls can return a sequence of DQRR entries, without * requiring they be consumed immediately or in any particular order. */ -inline const struct qbman_result *qbman_swp_dqrr_next(struct qbman_swp *s) +const struct qbman_result *qbman_swp_dqrr_next(struct qbman_swp *s) { return qbman_swp_dqrr_next_ptr(s); } @@ -2129,7 +2129,7 @@ static int qbman_swp_release_mem_back(struct qbman_swp *s, return 0; } -inline int qbman_swp_release(struct qbman_swp *s, +int qbman_swp_release(struct qbman_swp *s, const struct qbman_release_desc *d, const uint64_t *buffers, unsigned int num_buffers)