From patchwork Wed May 13 12:06:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nithin Dabilpuram X-Patchwork-Id: 70166 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1C5CA034F; Wed, 13 May 2020 14:06:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39A4F1D55A; Wed, 13 May 2020 14:06:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id E991B1D553 for ; Wed, 13 May 2020 14:06:16 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04DC1QP1032488; Wed, 13 May 2020 05:06:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pfpt0818; bh=NgkUxBgm/gVXmHR0YN82fO9LsUfgZ1Y2xZtPGyHl3D4=; b=NIwRn5xOkd8bMF4AOAMj77l8GJZZ0ayK5aAiDz+vdaGh+rVpGr3rnXiiNCNwh8fXgzKs 6GoDtqjJENA/JHw00M2XIBDbdCCCiSLLPUsJwrxO758SkhhOykXueqD3UiU/DcU/zLPG zDxrZZpSe4IL+ZtKl64ttJv12SGVcLPS2yMk6ILt/kAl78BprHFUs6IP8QxjumcFpfYg REQul11U6qCTF2YsSVXz5PZ+L585cUdDvMQrC0UDZsFLC9KsNExq7yooTnk6OyH1xfdO FvN47Qba79XJM2Ig3+1AMR6FNYo8rvOkQY4MA4oIiRQRnFRbP3KxTsjI6SGRNIfckXzb vA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 3100xac8qs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 13 May 2020 05:06:11 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 13 May 2020 05:06:09 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 13 May 2020 05:06:10 -0700 Received: from hyd1588t430.marvell.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id D46B63F703F; Wed, 13 May 2020 05:06:07 -0700 (PDT) From: Nithin Dabilpuram To: , , , Nithin Dabilpuram , Pavan Nikhilesh CC: , Date: Wed, 13 May 2020 17:36:04 +0530 Message-ID: <20200513120605.28912-1-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.8.4 In-Reply-To: <20200513054816.18848-1-ndabilpuram@marvell.com> References: <20200513054816.18848-1-ndabilpuram@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-13_04:2020-05-11, 2020-05-13 signatures=0 Subject: [dpdk-dev] [PATCH v2] node: fix arm64 build issue for older gcc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Older GCC(~4) complains about uninitialized 'dip' var though all the lanes of the vec register are set. Hence this patch explicitly initializes vec register to fix the issue. In file included from ip4_lookup.c:34:0: ip4_lookup_neon.h: n function ‘ip4_lookup_node_process’: \ ip4_lookup_neon.h:25:12: error: ‘dip’ may be used uninitialized in \ this function [-Werror=maybe-uninitialized] int32x4_t dip; ^ Fixes: 16df6a2c6671 ("node: add IPv4 lookup for arm64") Signed-off-by: Nithin Dabilpuram Reviewed-by: Ruifeng Wang Reported-by: David Marchand Reviewed-by: Jerin Jacob --- v2: - Add error in commit msg. lib/librte_node/ip4_lookup_neon.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_node/ip4_lookup_neon.h b/lib/librte_node/ip4_lookup_neon.h index bb3150f..dd21cb2 100644 --- a/lib/librte_node/ip4_lookup_neon.h +++ b/lib/librte_node/ip4_lookup_neon.h @@ -45,6 +45,7 @@ ip4_lookup_node_process(struct rte_graph *graph, struct rte_node *node, rte_prefetch0(rte_pktmbuf_mtod_offset(pkts[i], void *, sizeof(struct rte_ether_hdr))); + dip = vdupq_n_s32(0); /* Get stream for the speculated next node */ to_next = rte_node_next_stream_get(graph, node, next_index, nb_objs); while (n_left_from >= 4) {