diff mbox series

[v3] examples/ipsec-secgw: fix negative argument passing

Message ID 20200506110241.21118-1-praveen.shetty@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v3] examples/ipsec-secgw: fix negative argument passing |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS

Commit Message

Shetty, Praveen May 6, 2020, 11:02 a.m. UTC 
  Function create_ipsec_esp_flow returns a negative number in case of any
failure and we are passing this to strerror to display the error message.
But strerror()'s argument cannot be negative.
In case of failure, displaying exact error message to console is handled
in create_ipsec_esp_flow function.So it is not required to print the
error message again using strerror.
This patch will remove the unnecessary calling of strerror function
to fix the negative argument passing to strerror issue.

Coverity issue: 357691
Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director")
Cc: praveen.shetty@intel.com

Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
---
v3 changes:
fixed typo in commit message.

 examples/ipsec-secgw/sa.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Anoob Joseph May 7, 2020, 4:18 a.m. UTC | #1 
> Function create_ipsec_esp_flow returns a negative number in case of any failure
> and we are passing this to strerror to display the error message.
> But strerror()'s argument cannot be negative.
> In case of failure, displaying exact error message to console is handled in
> create_ipsec_esp_flow function.So it is not required to print the error message
> again using strerror.
> This patch will remove the unnecessary calling of strerror function to fix the
> negative argument passing to strerror issue.
> 
> Coverity issue: 357691
> Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director")
> Cc: praveen.shetty@intel.com
> 
> Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
> Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>

Acked-by: Anoob Joseph <anoobj@marvell.com>
Akhil Goyal May 9, 2020, 10:02 p.m. UTC | #2 
> > Function create_ipsec_esp_flow returns a negative number in case of any
> failure
> > and we are passing this to strerror to display the error message.
> > But strerror()'s argument cannot be negative.
> > In case of failure, displaying exact error message to console is handled in
> > create_ipsec_esp_flow function.So it is not required to print the error message
> > again using strerror.
> > This patch will remove the unnecessary calling of strerror function to fix the
> > negative argument passing to strerror issue.
> >
> > Coverity issue: 357691
> > Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director")
> > Cc: praveen.shetty@intel.com
> >
> > Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
> > Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
> 
> Acked-by: Anoob Joseph <anoobj@marvell.com>

Applied to dpdk-next-crypto

Thanks.
diff mbox series

Patch

diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index e3a1a5aff..632482176 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -1223,8 +1223,7 @@  sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[],
 			rc = create_ipsec_esp_flow(sa);
 			if (rc != 0)
 				RTE_LOG(ERR, IPSEC_ESP,
-					"create_ipsec_esp_flow() failed %s\n",
-					strerror(rc));
+					"create_ipsec_esp_flow() failed\n");
 		}
 		print_one_sa_rule(sa, inbound);
 	}