From patchwork Wed Apr 22 22:30:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 69158 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58D09A00C2; Thu, 23 Apr 2020 00:30:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 368271C440; Thu, 23 Apr 2020 00:30:08 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 97E591C439 for ; Thu, 23 Apr 2020 00:30:06 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id c21so701110plz.4 for ; Wed, 22 Apr 2020 15:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QotA30hOurpBYu7Pst62yLBwQk4iKxGx/dbX//4HVW4=; b=dNxomlcfV6fPh7of4vtED4zJAXlSVpw968oQxPphohOEWPbGzpNUyvqXGImp7bE/VC r/QvUMYfVwpJg+/b1f29xtkV2dQiVhaPiVnUxIfKMYf6OXhe85e3+x4Z1tREc0hvfUdu L2ulLOa/U/n8AV2HXRpipiZjX+PgsXyQzhRGnJ8uKfkRefX2htTi6LxaIzkACmBgqWcy RqfstpqlahaKfnU1UX8ZzYUemnYByLIBYzd0DFrGo+cZLvs1+TbFo4T9LI9ev7FsUxf0 RaWNKW+L2KrcKAOS5NBHblGhX8j5yzhKOl9CV6gt3RpV+7HNUBCCqdlh/Pf4h20T5YbD xS0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QotA30hOurpBYu7Pst62yLBwQk4iKxGx/dbX//4HVW4=; b=TrjN6H7jh/3tc7qohmUL3n6yNtT50+lKnR7mp4rcPMlRFc+/Ep0j17qpoe2iVnN3Se zhUXDmafY+Zjj61p3goJRXoKYuvKsu4yeu4cN0tvy4bmVX6iRC5F78NJ8fn/nZ2UjMr3 aSHkdqQMH5wRrT6sqKC6xZT2hWqhw51JX8x1Boa1RUO+EH9EM/PD3oFvdYlNuRVue9op Ua+P5Rhi0zEIljHh1YIFc1KnF5bAttnF2NPfiNV5EOCvUlOp/twmJpEwWumOXB8MBNdS jWKGxkxzFU7I0H/N+zu17b1tcqDk0Feb3kOTt5s7DBPilJxM0NR8SZS8xMOK4MChiDkB DBog== X-Gm-Message-State: AGi0PuZVITkgPt/AEKoqKLrCQUSbqY1eqKGwVtsgEEEYJgeGKBXQH4c5 HLyK3GBJlgT7/27HoUjDJrFH6MeQgQU= X-Google-Smtp-Source: APiQypLm1IgwT6ybmgVWtYc59WTgZA0BetdC/gCy+Dp4Qv1unCueMV1LAiesS0wdpo5KCDro/zoWzQ== X-Received: by 2002:a17:902:b20e:: with SMTP id t14mr846913plr.223.1587594605313; Wed, 22 Apr 2020 15:30:05 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q200sm240346pgq.68.2020.04.22.15.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2020 15:30:04 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , nelio.laranjeiro@6wind.com Date: Wed, 22 Apr 2020 15:30:00 -0700 Message-Id: <20200422223000.16602-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] common/mlx5: reduce size of netlink buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since the driver is just using netlink to receive acknowledgements for command requests, having a large (32K) buffer is unnecessary. Allocating large buffers on stack will break in application is using smaller per-thread stacks. It looks like original code intended to use a smaller buffer for the read than the socket, so keep that set of defines. Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") Cc: nelio.laranjeiro@6wind.com Signed-off-by: Stephen Hemminger --- drivers/common/mlx5/mlx5_nl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/mlx5_nl.c b/drivers/common/mlx5/mlx5_nl.c index d9f0d4129e35..847e78dbcea6 100644 --- a/drivers/common/mlx5/mlx5_nl.c +++ b/drivers/common/mlx5/mlx5_nl.c @@ -28,7 +28,7 @@ /* Size of the buffer to receive kernel messages */ -#define MLX5_NL_BUF_SIZE (32 * 1024) +#define MLX5_NL_BUF_SIZE 4096 /* Send buffer size for the Netlink socket */ #define MLX5_SEND_BUF_SIZE 32768 /* Receive buffer size for the Netlink socket */ @@ -330,7 +330,7 @@ mlx5_nl_recv(int nlsk_fd, uint32_t sn, int (*cb)(struct nlmsghdr *, void *arg), void *arg) { struct sockaddr_nl sa; - char buf[MLX5_RECV_BUF_SIZE]; + char buf[MLX5_NL_BUF_SIZE]; struct iovec iov = { .iov_base = buf, .iov_len = sizeof(buf),