ipsec: fix build dependency on hash lib

Message ID 20200416112517.3386-1-akhil.goyal@nxp.com (mailing list archive)
State Accepted, archived
Headers
Series ipsec: fix build dependency on hash lib |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation fail apply issues

Commit Message

Akhil Goyal April 16, 2020, 11:25 a.m. UTC
  rte_ipsec has a dependancy on rte_hash
So we need the librte_hash to be compiled before librte_ipsec.
Add the DEPDIRs to make sure this.

Fixes: 3feb23609cae ("ipsec: add SAD create/destroy implementation")
Cc:stable@dpdk.org

Reported-by: Raslan Darawsheh <rasland@mellanox.com>
Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Thomas Monjalon April 16, 2020, 12:19 p.m. UTC | #1
16/04/2020 13:25, Akhil Goyal:
> rte_ipsec has a dependancy on rte_hash

dependency

> So we need the librte_hash to be compiled before librte_ipsec.
> Add the DEPDIRs to make sure this.
> 
> Fixes: 3feb23609cae ("ipsec: add SAD create/destroy implementation")
> Cc:stable@dpdk.org

missing a space after :

> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied, thanks
  

Patch

diff --git a/lib/Makefile b/lib/Makefile
index 46b91ae1a..2cbb096f1 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -113,7 +113,7 @@  DIRS-$(CONFIG_RTE_LIBRTE_BPF) += librte_bpf
 DEPDIRS-librte_bpf := librte_eal librte_mempool librte_mbuf librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_IPSEC) += librte_ipsec
 DEPDIRS-librte_ipsec := librte_eal librte_mbuf librte_cryptodev librte_security \
-			librte_net
+			librte_net librte_hash
 DIRS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += librte_telemetry
 DEPDIRS-librte_telemetry := librte_eal librte_metrics librte_ethdev
 DIRS-$(CONFIG_RTE_LIBRTE_RCU) += librte_rcu