From patchwork Fri Feb 21 16:10:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 65990 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31CF2A0525; Fri, 21 Feb 2020 17:10:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 389B81BFAC; Fri, 21 Feb 2020 17:10:26 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 0D33F1BFA9 for ; Fri, 21 Feb 2020 17:10:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582301424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KTUGiCVTYQLXBilJL9ni4wHz7LZYnbkZFJ9GoUooaqM=; b=ilk+i/JONFwfy8Ufqiwm7ffkANJD1hO7o63eTbjYDx399NkeoSBSt9c2/C3awNnxBRyhoO D+ZU9xoki8f8O0cBgtg4FjYknVI+qB3XUePLEfB7sy/wPWb2RLEBi9sMm7Y11x9M2X1z6U wjPy3C9v7Lc8tEF72N8Wh4Hrul9g0Vc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-192--SlwnMKjOXms-HNO1crCPQ-1; Fri, 21 Feb 2020 11:10:17 -0500 X-MC-Unique: -SlwnMKjOXms-HNO1crCPQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 183A9A0CCC; Fri, 21 Feb 2020 16:10:16 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-34.brq.redhat.com [10.40.204.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id C45589076C; Fri, 21 Feb 2020 16:10:11 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@intel.com, dodji@redhat.com Date: Fri, 21 Feb 2020 17:10:05 +0100 Message-Id: <20200221161005.18557-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] devtools: skip experimental libraries in ABI check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" We don't provide ABI compatibility for experimental libraries. Skip those libraries by catching a soname containing a version starting with '0.'. Align the special case for the glue libraries by using the soname too. Once libabigail has support for it, we will have a single type of rule. Fixes: 777014e56d07 ("devtools: add ABI checks") Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- devtools/check-abi.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh index 0b4d1a37e..dd9120e69 100755 --- a/devtools/check-abi.sh +++ b/devtools/check-abi.sh @@ -40,8 +40,13 @@ for dump in $(find $refdir -name "*.dump"); do # skip glue drivers, example librte_pmd_mlx5_glue.dump # We can't rely on a suppression rule for now: # https://sourceware.org/bugzilla/show_bug.cgi?id=25480 - if [ "$name" != "${name%%_glue.dump}" ]; then - echo "Skipping ${dump}..." + if grep -qE "\