diff mbox series

[v2] net/iavf: fix Rx total stats

Message ID 20191213012329.3935-1-jiaqix.min@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series [v2] net/iavf: fix Rx total stats |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation fail apply issues

Commit Message

Min, JiaqiX Dec. 13, 2019, 1:23 a.m. UTC 
Rx total stats is the total number of successfully received packets,
so exclude the number of rx_discards for Rx total stats.

Fixes: f4a41a6953af ("net/avf: support stats")
Cc: stable@dpdk.org

Signed-off-by: Jiaqi Min <jiaqix.min@intel.com>
---
v2:
* Changed commit message.
---
 drivers/net/iavf/iavf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jingjing Wu Dec. 13, 2019, 7:16 a.m. UTC | #1 
> -----Original Message-----
> From: Min, JiaqiX <jiaqix.min@intel.com>
> Sent: Friday, December 13, 2019 9:23 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Min, JiaqiX
> <jiaqix.min@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/iavf: fix Rx total stats
> 
> Rx total stats is the total number of successfully received packets,
> so exclude the number of rx_discards for Rx total stats.
> 
> Fixes: f4a41a6953af ("net/avf: support stats")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jiaqi Min <jiaqix.min@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Xiaolong Ye Dec. 13, 2019, 7:57 a.m. UTC | #2 
On 12/13, Wu, Jingjing wrote:
>
>
>> -----Original Message-----
>> From: Min, JiaqiX <jiaqix.min@intel.com>
>> Sent: Friday, December 13, 2019 9:23 AM
>> To: dev@dpdk.org
>> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Min, JiaqiX
>> <jiaqix.min@intel.com>; stable@dpdk.org
>> Subject: [PATCH v2] net/iavf: fix Rx total stats
>> 
>> Rx total stats is the total number of successfully received packets,
>> so exclude the number of rx_discards for Rx total stats.
>> 
>> Fixes: f4a41a6953af ("net/avf: support stats")
>> Cc: stable@dpdk.org
>> 
>> Signed-off-by: Jiaqi Min <jiaqix.min@intel.com>
>Acked-by: Jingjing Wu <jingjing.wu@intel.com>
>
>

Applied to dpdk-next-net-intel, Thanks.
diff mbox series

Patch

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index a39ba1466..f544303c0 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1068,7 +1068,7 @@  iavf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	if (ret == 0) {
 		iavf_update_stats(vsi, pstats);
 		stats->ipackets = pstats->rx_unicast + pstats->rx_multicast +
-						pstats->rx_broadcast;
+				pstats->rx_broadcast - pstats->rx_discards;
 		stats->opackets = pstats->tx_broadcast + pstats->tx_multicast +
 						pstats->tx_unicast;
 		stats->imissed = pstats->rx_discards;