devtools: move ABI scripts from buildtools
Checks
Commit Message
Those scripts are only used by developers and not part of the build
process.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
MAINTAINERS | 8 ++++----
{buildtools => devtools}/check-abi-version.sh | 0
{buildtools => devtools}/update-abi.sh | 2 +-
{buildtools => devtools}/update_version_map_abi.py | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
rename {buildtools => devtools}/check-abi-version.sh (100%)
rename {buildtools => devtools}/update-abi.sh (95%)
rename {buildtools => devtools}/update_version_map_abi.py (99%)
Comments
28/11/2019 14:46, David Marchand:
> Those scripts are only used by developers and not part of the build
> process.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
I hesitated to accept these scripts in buildtools.
I agree it is better in devtools, and not installed.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
On Thu, Nov 28, 2019 at 3:23 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 28/11/2019 14:46, David Marchand:
> > Those scripts are only used by developers and not part of the build
> > process.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> I hesitated to accept these scripts in buildtools.
> I agree it is better in devtools, and not installed.
Yes, forgot to mention that update_version_map_abi.py raised an issue
in the Centos 8 packaging test in OBS.
Relooking at those scripts, there is no reason to install them as part
of a dpdk package.
On Thu, Nov 28, 2019 at 3:23 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> 28/11/2019 14:46, David Marchand:
> > Those scripts are only used by developers and not part of the build
> > process.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks.
@@ -143,13 +143,13 @@ M: Neil Horman <nhorman@tuxdriver.com>
F: lib/librte_eal/common/include/rte_compat.h
F: lib/librte_eal/common/include/rte_function_versioning.h
F: doc/guides/rel_notes/deprecation.rst
-F: devtools/validate-abi.sh
+F: devtools/check-abi-version.sh
F: devtools/check-symbol-change.sh
-F: buildtools/check-abi-version.sh
+F: devtools/update-abi.sh
+F: devtools/update_version_map_abi.py
+F: devtools/validate-abi.sh
F: buildtools/check-experimental-syms.sh
F: buildtools/map-list-symbol.sh
-F: buildtools/update-abi.sh
-F: buildtools/update_version_map_abi.py
Driver information
M: Neil Horman <nhorman@tuxdriver.com>
similarity index 100%
rename from buildtools/check-abi-version.sh
rename to devtools/check-abi-version.sh
similarity index 95%
rename from buildtools/update-abi.sh
rename to devtools/update-abi.sh
@@ -42,5 +42,5 @@ echo "Path to update:" $update_path
echo $abi_version > $abi_version_file
find $update_path -name \*version.map -exec \
- ./buildtools/update_version_map_abi.py {} \
+ devtools/update_version_map_abi.py {} \
$abi_version \; -print
similarity index 99%
rename from buildtools/update_version_map_abi.py
rename to devtools/update_version_map_abi.py
@@ -6,7 +6,7 @@
A Python program that updates and merges all available stable ABI versions into
one ABI version, while leaving experimental ABI exactly as it is. The intended
ABI version is supplied via command-line parameter. This script is to be called
-from the buildtools/update-abi.sh utility.
+from the devtools/update-abi.sh utility.
"""
from __future__ import print_function