From patchwork Thu Oct 17 22:21:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Christensen X-Patchwork-Id: 61444 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A58161D447; Fri, 18 Oct 2019 00:21:14 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 25A021D445 for ; Fri, 18 Oct 2019 00:21:13 +0200 (CEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x9HMHVk6092024 for ; Thu, 17 Oct 2019 18:21:12 -0400 Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com with ESMTP id 2vq0hjgxwq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 Oct 2019 18:21:11 -0400 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x9HMFeEO005449 for ; Thu, 17 Oct 2019 22:21:10 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma05wdc.us.ibm.com with ESMTP id 2vq0bqr8rb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 Oct 2019 22:21:10 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x9HML7pH51904882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Oct 2019 22:21:07 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D3827AC05F; Thu, 17 Oct 2019 22:21:07 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC886AC059; Thu, 17 Oct 2019 22:21:07 +0000 (GMT) Received: from localhost.localdomain (unknown [9.114.224.51]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 17 Oct 2019 22:21:07 +0000 (GMT) From: David Christensen To: dev@dpdk.org Cc: David Christensen Date: Thu, 17 Oct 2019 15:21:05 -0700 Message-Id: <20191017222105.105667-1-drc@linux.vnet.ibm.com> X-Mailer: git-send-email 2.18.1 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-10-17_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910170194 Subject: [dpdk-dev] [PATCH] app/test: add tests for atomic exchanges X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The test works by creating a token comprised of random data and a CRC8 value, using the rte_atomicXX_exchange to exchange the new token for a previously generated token, and then verifying that the exchanged data is intact (i.e. the CRC8 is still correct for the data). Signed-off-by: David Christensen --- app/test/test_atomic.c | 173 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 171 insertions(+), 2 deletions(-) diff --git a/app/test/test_atomic.c b/app/test/test_atomic.c index 43be30ec0..4a818b6d5 100644 --- a/app/test/test_atomic.c +++ b/app/test/test_atomic.c @@ -1,10 +1,12 @@ /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2010-2014 Intel Corporation + * Copyright(c) 2019 Arm Limited */ #include #include #include +#include #include #include @@ -13,6 +15,8 @@ #include #include #include +#include +#include #include "test.h" @@ -20,7 +24,7 @@ * Atomic Variables * ================ * - * - The main test function performs three subtests. The first test + * - The main test function performs four subtests. The first test * checks that the usual inc/dec/add/sub functions are working * correctly: * @@ -61,11 +65,26 @@ * atomic_sub(&count, tmp+1); * * - At the end of the test, the *count* value must be 0. + * + * - Test "atomic exchange" + * + * - Create a 64 bit token that can be tested for data integrity + * + * - Invoke ``test_atomic_exchange`` on each lcore. Before doing + * anything else, the cores wait for a synchronization event. + * Each core then does the follwoing for N iterations: + * + * Generate a new token with a data integrity check + * Exchange the new token for previously generated token + * Increment a counter if a corrupt token was received + * + * - At the end of the test, the number of corrupted tokens must be 0. + * */ #define NUM_ATOMIC_TYPES 3 -#define N 10000 +#define N 1000000 static rte_atomic16_t a16; static rte_atomic32_t a32; @@ -216,6 +235,124 @@ test_atomic_dec_and_test(__attribute__((unused)) void *arg) return 0; } +/* + * Helper definitions/variables/functions for + * atomic exchange tests + */ +typedef union { + uint16_t u16; + uint8_t u8[2]; +} rte_u16_t; + +typedef union { + uint32_t u32; + uint16_t u16[2]; + uint8_t u8[4]; +} rte_u32_t; + +typedef union { + uint64_t u64; + uint32_t u32[2]; + uint16_t u16[4]; + uint8_t u8[8]; +} rte_u64_t; + +const uint8_t CRC8_POLY = 0x91; +uint8_t crc8_table[256]; + +volatile uint16_t token16; +volatile uint32_t token32; +volatile uint64_t token64; + +static void +build_crc8_table(void) +{ + uint8_t val; + + for (int i = 0; i < 256; i++) { + val = i; + for (int j = 0; j < 8; j++) { + if (val & 1) + val ^= CRC8_POLY; + val >>= 1; + } + crc8_table[i] = val; + } +} + +static uint8_t +get_crc8(uint8_t *message, int length) +{ + uint8_t crc = 0; + + for (int i = 0; i < length; i++) + crc = crc8_table[crc ^ message[i]]; + return crc; +} + +/* + * The atomic exchange test sets up a token in memory and + * then spins up multiple lcores whose job is to generate + * new tokens, exchange that new token for the old one held + * in memory, and then verify that the old token is still + * valid (i.e. the exchange did not corrupt the token). + * + * A token is made up of random data and 8 bits of crc + * covering that random data. The following is an example + * of a 64bit token. + * + * +------------+------------+ + * | 63 56 | 55 0 | + * +------------+------------+ + * | CRC8 | Data | + * +------------+------------+ + */ +static int +test_atomic_exchange(__attribute__((unused)) void *arg) +{ + rte_u16_t nt16, ot16; /* new token, old token */ + rte_u32_t nt32, ot32; + rte_u64_t nt64, ot64; + + /* Wait until all of the other threads have been dispatched */ + while (rte_atomic32_read(&synchro) == 0) + ; + + /* + * Let the battle begin! Every thread attempts to steal the current + * token with an atomic exchange operation and install its own newly + * generated token. If the old token is valid (i.e. it has the + * appropriate crc32 hash for the data) then the test iteration has + * passed. If the token is invalid, increment the counter. + */ + for (int i = 0; i < N; i++) { + + /* Test 64bit Atomic Exchange */ + nt64.u64 = rte_rand(); + nt64.u8[7] = get_crc8(&nt64.u8[0], sizeof(nt64) - 1); + ot64.u64 = rte_atomic64_exchange(&token64, nt64.u64); + if (ot64.u8[7] != get_crc8(&ot64.u8[0], sizeof(ot64) - 1)) + rte_atomic64_inc(&count); + + /* Test 32bit Atomic Exchange */ + nt32.u32 = (uint32_t)rte_rand(); + nt32.u8[3] = get_crc8(&nt32.u8[0], sizeof(nt32) - 1); + ot32.u32 = rte_atomic32_exchange(&token32, nt32.u32); + if (ot32.u8[3] != get_crc8(&ot32.u8[0], sizeof(ot32) - 1)) + rte_atomic64_inc(&count); + + /* Test 16bit Atomic Exchange */ + nt16.u16 = (uint16_t)rte_rand(); + nt16.u8[1] = get_crc8(&nt16.u8[0], sizeof(nt16) - 1); + ot16.u16 = rte_atomic16_exchange(&token16, nt16.u16); + if (ot16.u8[1] != get_crc8(&ot16.u8[0], sizeof(ot16) - 1)) + te_atomic64_inc(&count); + } + + return 0; +} + + static int test_atomic(void) { @@ -340,6 +477,38 @@ test_atomic(void) return -1; } + /* + * Test 16/32/64bit atomic exchange. + */ + rte_u64_t t; + + printf("exchange test\n"); + + rte_atomic32_clear(&synchro); + rte_atomic64_clear(&count); + + /* Generate the CRC8 lookup table */ + build_crc8_table(); + + /* Create the initial tokens used by the test */ + t.u64 = rte_rand(); + token16 = (get_crc8(&t.u8[0], sizeof(token16) - 1) << 8) + | (t.u16[0] & 0x00ff); + token32 = ((uint32_t)get_crc8(&t.u8[0], sizeof(token32) - 1) << 24) + | (t.u32[0] & 0x00ffffff); + token64 = ((uint64_t)get_crc8(&t.u8[0], sizeof(token64) - 1) << 56) + | (t.u64 & 0x00ffffffffffffff); + + rte_eal_mp_remote_launch(test_atomic_exchange, NULL, SKIP_MASTER); + rte_atomic32_set(&synchro, 1); + rte_eal_mp_wait_lcore(); + rte_atomic32_clear(&synchro); + + if (rte_atomic64_read(&count) > 0) { + printf("Atomic exchange test failed\n"); + return -1; + } + return 0; }