| Message ID | 20191015070112.92937-1-asomalap@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | akhil goyal |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 254A01D37F; Tue, 15 Oct 2019 09:01:40 +0200 (CEST) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-eopbgr780043.outbound.protection.outlook.com [40.107.78.43]) by dpdk.org (Postfix) with ESMTP id 96F031D160; Tue, 15 Oct 2019 09:01:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W93F+RiiaFECBXUUvMyLYbkLShT/03VN6vKr+Hc1IMSuUSgirVEtflpCwOVNl/kiVUCMoPe6QaNx80mvIIJ2L91Wtf5YLKPYGKenfPk1fAPV+riugGWP4GxPjhgKONuRC2Fh2L5QILY5dEMhG9sdiEznmlyC2Zavu2psIyYwLAN5vdqGWCmyVRSTcCqRZyxxjBgN7B8YjKQeFzu4jfhol2C8WN6nirm+OY3wqpiP6P6VK5l1SUgwU3JT+FtqTCPff71ZrJ6K/jm0OMuiRxQW8mwLCSQTHP5vJ40TfCC2wU4Zy0usDt2A8NbCdYb2S7TlmxGEeGRYhakhIV+wzsLPLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Z2pkgR761zVCXPJNmxdG99+WGmLs5F62PYIXZ3hlnA=; b=KXhYfY3e6OfJ8CItGsl7tRu4Y1SmffoogKtRpeEz3K1k77eWZqV2rEPEohjxB5SU/V/ZOLr+e9po2OZAC9Z2UZ5Gwuov2nCn+Rb7Ka4uZtrWg5CuJ1PI+ukXAjgzUqKaVIYgPfYkcfOEapdj38KxqKcqxmMeib5uYBFckuDPcJ2G1CChsgOZEOPYZD/4/h+tr99Dd6FRIHNFxizT4eQ54Heu0GHxR/GumHR8XkCvCRjOskLOQ78nzJpJ4sPwSVe24AyZ3PzFHN2dLLNAZMU/AqGV8X0a6YchJCelrcKotQNRXpsFOfFiaU8c/FU2nlLiup2kwBWrmsLQ2zeiBOCafQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Z2pkgR761zVCXPJNmxdG99+WGmLs5F62PYIXZ3hlnA=; b=mKHgNN7ERWZqYsxCOxjemDF6PjQ49IKWPR1Uzsn/we5bStRcc6vozA/tIPyjZEen9PMg/9fljhajyDk8N4waZhq6l1Us8wuZTa2PNUp6+TOUi2qc5Zt4EzfPwh6J3tHUNfG36KIunSWRFWFfglzuY0Ppg5int/wwWkTtE9tIaes= Received: from DM5PR1201MB2474.namprd12.prod.outlook.com (10.172.87.136) by DM5PR1201MB2472.namprd12.prod.outlook.com (10.172.86.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.19; Tue, 15 Oct 2019 07:01:37 +0000 Received: from DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::f3:94a5:9dbc:1fd5]) by DM5PR1201MB2474.namprd12.prod.outlook.com ([fe80::f3:94a5:9dbc:1fd5%12]) with mapi id 15.20.2347.023; Tue, 15 Oct 2019 07:01:37 +0000 From: <asomalap@amd.com> To: "dev@dpdk.org" <dev@dpdk.org> CC: "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used Thread-Index: AQHVgyZjqDIZFySiFUO55qa6IdDkVw== Date: Tue, 15 Oct 2019 07:01:37 +0000 Message-ID: <20191015070112.92937-1-asomalap@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0013.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::23) To DM5PR1201MB2474.namprd12.prod.outlook.com (2603:10b6:3:e3::8) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Amaranath.Somalapuram@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [165.204.156.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7511822c-6eaf-47da-dfc2-08d7513d8561 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: DM5PR1201MB2472: x-microsoft-antispam-prvs: <DM5PR1201MB247259A6378BEC72E1B90CE8F8930@DM5PR1201MB2472.namprd12.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:366; x-forefront-prvs: 01917B1794 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(366004)(376002)(39860400002)(396003)(189003)(199004)(305945005)(450100002)(81156014)(1076003)(25786009)(7736002)(81166006)(1730700003)(66476007)(66446008)(50226002)(8936002)(64756008)(316002)(8676002)(4744005)(2616005)(71190400001)(71200400001)(6916009)(2906002)(99286004)(36756003)(66556008)(6506007)(386003)(6486002)(102836004)(14444005)(14454004)(2351001)(2501003)(256004)(52116002)(6436002)(186003)(486006)(66946007)(66066001)(5640700003)(476003)(5660300002)(26005)(4326008)(3846002)(6512007)(6116002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1201MB2472; H:DM5PR1201MB2474.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ypK8aZh1cJPVcEN3CTBIBjipsT7vg0qeaWDUGx7L8wOem6jtO0UpzALj35uHxvqw4q+zEVGCWxewY0em695SkYxIVS3HfBCy70/hAwDsNCnSWv2Jx30mYMPmX0+tgVFtRnZLpFUQBjQ3i9Agw53D6l5yK9mMLJsIbdgFYJRqAuHNE2u6QC/0rjw0Fm6mgxSMPmmxI2N18hZFC0H9h1xtrilQTB5CDT4CtlArWXow0OEA5zigsg0xAcgvYa++ZHrbHJ/nbXSijlcYCUMi14LaIEY6hrkIOoq3acHJcQaoHBtVmkhLUK41eBWD9zhidg1PFO2gKXVxbp/05L9KMzEtuQzvIETO17RH0bnBxY96BFO9zOLl+fHWUgzZek0HR+NAs+b8gleoSqg+V5Hg5pjj69kdf0OXZKXpCbQQ27D1mzU= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7511822c-6eaf-47da-dfc2-08d7513d8561 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2019 07:01:37.3661 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TBRg1XBiCNjVuJ2T/Du/xnnx6lwV8frWps7R93Kbw1CRDCFjOovYiSirh4AFXp6bRAkrGlyVaxeJUcMvyGu7zQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2472 Subject: [dpdk-dev] [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
[v1,1/6] doc: documentation update
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | success | coding style OK |
Commit Message
AMARANATH SOMALAPURAM
Oct. 15, 2019, 7:01 a.m. UTC
From: Amaranath Somalapuram <asomalap@amd.com> when ccp_auth_opt=1 is set and if authentication error occurred ccp driver crash. proble is enqueue count and dequeue count miss match if we continue. Cc: stable@dpdk.org Signed-off-by: Amaranath Somalapuram <asomalap@amd.com> --- drivers/crypto/ccp/ccp_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Title: crypto/ccp: fix CPU authentication crash > > From: Amaranath Somalapuram <asomalap@amd.com> > > when ccp_auth_opt=1 is set and > if authentication error occurred ccp driver crash. > proble is enqueue count and dequeue count miss match if we continue. Please rephrase this description. Fixes line?? > Cc: stable@dpdk.org > > Signed-off-by: Amaranath Somalapuram <asomalap@amd.com> > --- > drivers/crypto/ccp/ccp_crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c > index 19ae9153d..1837c8543 100644 > --- a/drivers/crypto/ccp/ccp_crypto.c > +++ b/drivers/crypto/ccp/ccp_crypto.c > @@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp, > session, auth_ctx); > if (op[i]->status != > RTE_CRYPTO_OP_STATUS_SUCCESS) > - continue; > + > CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED"); > } else > result = ccp_crypto_auth(op[i], cmd_q, b_info); > > -- > 2.17.1
Hi Akhil, Not sure about how to use fix line if I don't have bug number. If I run ./devtools/check-git-log.sh it expect bug number. Do you recommend to log a bug for my patches ?? Please let me know. Regards, S.Amarnath -----Original Message----- From: Akhil Goyal <akhil.goyal@nxp.com> Sent: Tuesday, October 15, 2019 4:31 PM To: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>; dev@dpdk.org Cc: stable@dpdk.org Subject: RE: [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used [CAUTION: External Email] Title: crypto/ccp: fix CPU authentication crash > > From: Amaranath Somalapuram <asomalap@amd.com> > > when ccp_auth_opt=1 is set and > if authentication error occurred ccp driver crash. > proble is enqueue count and dequeue count miss match if we continue. Please rephrase this description. Fixes line?? > Cc: stable@dpdk.org > > Signed-off-by: Amaranath Somalapuram <asomalap@amd.com> > --- > drivers/crypto/ccp/ccp_crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/ccp/ccp_crypto.c > b/drivers/crypto/ccp/ccp_crypto.c index 19ae9153d..1837c8543 100644 > --- a/drivers/crypto/ccp/ccp_crypto.c > +++ b/drivers/crypto/ccp/ccp_crypto.c > @@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp, > session, auth_ctx); > if (op[i]->status != > RTE_CRYPTO_OP_STATUS_SUCCESS) > - continue; > + > CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED"); > } else > result = ccp_crypto_auth(op[i], cmd_q, > b_info); > > -- > 2.17.1
Hi,
Please refer coding guidelines at https://doc.dpdk.org/guides/contributing/patches.html
Here is the example of a fix commit. In this "abcdefgh1234" is the commit id which introduced this issue.
You can check the commit id of the changed commit using git blame <file name>.
doc: fix some parameter description
Update the docs, fixing description of some parameter.
Fixes: abcdefgh1234 ("doc: add some parameter")
Cc: author@example.com
Signed-off-by: Alex Smith <alex.smith@example.com>
>
> Hi Akhil,
>
> Not sure about how to use fix line if I don't have bug number.
>
> If I run ./devtools/check-git-log.sh it expect bug number.
> Do you recommend to log a bug for my patches ??
>
> Please let me know.
>
> Regards,
> S.Amarnath
>
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Tuesday, October 15, 2019 4:31 PM
> To: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>;
> dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication
> is used
>
> [CAUTION: External Email]
>
> Title: crypto/ccp: fix CPU authentication crash
> >
> > From: Amaranath Somalapuram <asomalap@amd.com>
> >
> > when ccp_auth_opt=1 is set and
> > if authentication error occurred ccp driver crash.
> > proble is enqueue count and dequeue count miss match if we continue.
> Please rephrase this description.
>
> Fixes line??
>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> > ---
> > drivers/crypto/ccp/ccp_crypto.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/ccp/ccp_crypto.c
> > b/drivers/crypto/ccp/ccp_crypto.c index 19ae9153d..1837c8543 100644
> > --- a/drivers/crypto/ccp/ccp_crypto.c
> > +++ b/drivers/crypto/ccp/ccp_crypto.c
> > @@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp,
> > session, auth_ctx);
> > if (op[i]->status !=
> > RTE_CRYPTO_OP_STATUS_SUCCESS)
> > - continue;
> > +
> > CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED");
> > } else
> > result = ccp_crypto_auth(op[i], cmd_q,
> > b_info);
> >
> > --
> > 2.17.1
diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c index 19ae9153d..1837c8543 100644 --- a/drivers/crypto/ccp/ccp_crypto.c +++ b/drivers/crypto/ccp/ccp_crypto.c @@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp, session, auth_ctx); if (op[i]->status != RTE_CRYPTO_OP_STATUS_SUCCESS) - continue; + CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED"); } else result = ccp_crypto_auth(op[i], cmd_q, b_info);